Re: [PATCH v2] tcp: splice as many packets as possible at once

Jarek Poplawski
2009-01-20T10:21:20Z

On Tue, Jan 20, 2009 at 01:00:43PM +0300, Evgeniy Polyakov wrote:
> Hi Jarek.

Hi Evgeniy.
...
> > diff --git a/include/net/sock.h b/include/net/sock.h
> > index 5a3a151..4ded741 100644
> > --- a/include/net/sock.h
> > +++ b/include/net/sock.h
> > @@ -190,6 +190,8 @@ struct sock_common {
> > * @sk_user_data: RPC layer private data
> > * @sk_sndmsg_page: cached page for sendmsg
> > * @sk_sndmsg_off: cached offset for sendmsg
> > + * @sk_splice_page: cached page for splice
> > + * @sk_splice_off: cached offset for splice
>
> Ugh, increase every socket by 16 bytes... Does TCP one still fit the
> page?

Good question! Alas I can't check this soon, but if it's really like
this, of course this needs some better idea and rework. (BTW, I'd like
to prevent here as much as possible some strange activities like 1
byte (payload) packets getting full pages without any accounting.)

Thanks,
Jarek P.