From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754213AbZBCMVk (ORCPT ); Tue, 3 Feb 2009 07:21:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752084AbZBCMVb (ORCPT ); Tue, 3 Feb 2009 07:21:31 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:35560 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbZBCMVa (ORCPT ); Tue, 3 Feb 2009 07:21:30 -0500 Date: Tue, 3 Feb 2009 13:21:12 +0100 From: Ingo Molnar To: Jeremy Fitzhardinge , "H. Peter Anvin" Cc: the arch/x86 maintainers , Xen-devel , Linux Kernel Mailing List Subject: Re: [PATCH] xen: fix 32-bit build resulting from mmu move Message-ID: <20090203122112.GD19979@elte.hu> References: <49876C6E.3010809@goop.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49876C6E.3010809@goop.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Jeremy Fitzhardinge wrote: > Moving the mmu code from enlighten.c to mmu.c inadvertently broke the > 32-bit build. Fix it. > > Signed-off-by: Jeremy Fitzhardinge > --- > arch/x86/xen/mmu.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) that goes on top of the recent tip/x86/paravirt changes, right? No objections, i'm wondering why my testing didnt find any build breakage. Could you send me a .config that triggers the breakage? Ingo