From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Jens Axboe <jens.axboe@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH tip 1/3] trace: better manage the context info for events
Date: Tue, 3 Feb 2009 11:15:08 -0200 [thread overview]
Message-ID: <20090203131508.GD17781@ghostprotocols.net> (raw)
In-Reply-To: <alpine.DEB.1.10.0902022128130.2192@gandalf.stny.rr.com>
Em Mon, Feb 02, 2009 at 09:32:51PM -0500, Steven Rostedt escreveu:
> On Tue, 3 Feb 2009, Frederic Weisbecker wrote:
> > Now that I see the practical case, I'm not sure the design of my patch was valuable.
> > A tracer has to play with the flag if it wants to override the context info in
> > the bin/raw/hex cases. And I don't think this is a good way to proceed.
> >
> > In my opinion, the ITER_CONTEXT_INFO flag should mostly be set by the user.
>
> I think it should _only_ be set by user.
So we need a trace_event->binary_and_I_mean_it() callback that even if
the user wants, doesn't prints an ascii formatted context, as, for
tracers such as blkftrace, the binary trace has the context... in binary
:-)
- Arnaldo
next prev parent reply other threads:[~2009-02-03 13:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 22:29 [PATCH tip 1/3] trace: better manage the context info for events Arnaldo Carvalho de Melo
2009-02-03 2:07 ` Frederic Weisbecker
2009-02-03 2:32 ` Steven Rostedt
2009-02-03 9:09 ` Frederic Weisbecker
2009-02-03 12:57 ` Arnaldo Carvalho de Melo
2009-02-03 21:39 ` Frederic Weisbecker
2009-02-03 21:59 ` Arnaldo Carvalho de Melo
2009-02-03 22:02 ` Frederic Weisbecker
2009-02-03 12:54 ` Arnaldo Carvalho de Melo
2009-02-03 13:15 ` Arnaldo Carvalho de Melo [this message]
2009-02-03 12:50 ` Arnaldo Carvalho de Melo
2009-02-03 21:31 ` Frederic Weisbecker
2009-02-03 13:26 ` Ingo Molnar
2009-02-03 13:29 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090203131508.GD17781@ghostprotocols.net \
--to=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox