From: Ingo Molnar <mingo@elte.hu>
To: Arnaldo Carvalho de Melo <acme@redhat.com>,
Jens Axboe <jens.axboe@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH tip 1/1] blktrace: fix coding style in recent patches
Date: Tue, 3 Feb 2009 16:24:16 +0100 [thread overview]
Message-ID: <20090203152416.GH29046@elte.hu> (raw)
In-Reply-To: <20090203135829.GH17781@ghostprotocols.net>
* Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
> Impact: cleanup
>
> I introduced some, then, while testing with checkpatch --file
> block/blktrace.c I saw some long lines and fixed those too, some were
> even from older patches I sent, shame on me ;-\
>
> Cc: Jens Axboe <jens.axboe@oracle.com>
> Reported-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
applied to tip:tracing/blktrace, thanks Arnaldo!
btw., there's only one warning remaining in all of blktrace.c:
| CHECK: memory barrier without comment
| #555: FILE: blktrace.c:555:
| + smp_mb();
|
| total: 0 errors, 1 warnings, 1 checks, 1549 lines checked
and here checkpatch is kind of right that we should document this particular
smp_mb(). If you stick a comment in front of that statement, explaining that
barrier, then checkpatch will stop complaining.
Ingo
prev parent reply other threads:[~2009-02-03 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 13:58 [PATCH tip 1/1] blktrace: fix coding style in recent patches Arnaldo Carvalho de Melo
2009-02-03 15:24 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090203152416.GH29046@elte.hu \
--to=mingo@elte.hu \
--cc=acme@redhat.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox