From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
the arch/x86 maintainers <x86@kernel.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xen: fix 32-bit build resulting from mmu move
Date: Tue, 3 Feb 2009 19:14:25 +0100 [thread overview]
Message-ID: <20090203181425.GA4884@elte.hu> (raw)
In-Reply-To: <49888787.30803@goop.org>
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> Ingo Molnar wrote:
>> i have a lot of successful builds with that pattern, that's why i asked
>> for a specific config from you that definitely triggers it - i'd like
>> to investigate how it escaped my testing procedures.
>>
>
> Hm, I don't see how you could be; the functions are just outright
> missing. Without the patch, the attached config fails with:
>
> $ make 'ARCH=i386' arch/x86/xen/mmu.o
> [...]
> CC arch/x86/xen/mmu.o
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1810: error: 'xen_kmap_atomic_pte' undeclared here (not in a function)
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1816: error: 'xen_set_pte_init' undeclared here (not in a function)
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1824: error: initializer element is not constant
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1824: error: (near initialization for 'xen_mmu_ops.pte_val')
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1825: error: initializer element is not constant
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1825: error: (near initialization for 'xen_mmu_ops.pgd_val')
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1827: error: initializer element is not constant
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1827: error: (near initialization for 'xen_mmu_ops.make_pte')
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1828: error: initializer element is not constant
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1828: error: (near initialization for 'xen_mmu_ops.make_pgd')
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1838: error: initializer element is not constant
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1838: error: (near initialization for 'xen_mmu_ops.make_pmd')
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1839: error: initializer element is not constant
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1839: error: (near initialization for 'xen_mmu_ops.pmd_val')
> make[3]: *** [arch/x86/xen/mmu.o] Error 1
> make[2]: *** [arch/x86/xen/mmu.o] Error 2
> make[1]: *** [sub-make] Error 2
> make: *** [all] Error 2
>
hm, it triggers here too. Maybe the count of 32-bit tests wasnt high enough
yet to hit this.
Ingo
prev parent reply other threads:[~2009-02-03 18:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 21:58 [PATCH] xen: fix 32-bit build resulting from mmu move Jeremy Fitzhardinge
2009-02-03 12:21 ` Ingo Molnar
2009-02-03 17:14 ` Jeremy Fitzhardinge
2009-02-03 17:36 ` Ingo Molnar
2009-02-03 18:05 ` Jeremy Fitzhardinge
2009-02-03 18:14 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090203181425.GA4884@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox