Re: [PATCH tip 1/1] trace: judicious error checking of trace_seq results

Ingo Molnar
2009-02-04T19:47:06Z

* Arnaldo Carvalho de Melo <acme@redhat.com> wrote:

> Impact: bugfix/cleanup
>
> Some callsites were returning either TRACE_ITER_PARTIAL_LINE if the
> trace_seq routines (trace_seq_printf, etc) returned 0 meaning its buffer
> was full, or zero otherwise.
>
> But...
>
> /* Return values for print_line callback */
> enum print_line_t {
> TRACE_TYPE_PARTIAL_LINE = 0, /* Retry after flushing the seq */
> TRACE_TYPE_HANDLED = 1,
> TRACE_TYPE_UNHANDLED = 2 /* Relay to other output functions */
> };
>
> In other cases the return value was not being relayed at all.
>
> Most of the time it didn't hurt because the page wasn't get filled, but
> for correctness sake, handle the return values everywhere.

applied to tip:tracing/ftrace, thanks Arnaldo!

Ingo