Re: PCI PM: Restore standard config registers of all devices early

Benjamin Herrenschmidt
2009-02-03T04:04:55Z

On Mon, 2009-02-02 at 19:47 -0800, Linus Torvalds wrote:
>
> On Tue, 3 Feb 2009, Benjamin Herrenschmidt wrote:
> > On Tue, 2009-02-03 at 12:46 +1100, Benjamin Herrenschmidt wrote:
> > >
> > > Radeons don't do much with config space... the worst we may miss I
> > > suppose is subsystem vendor/device... Maybe I'll add something to
> > > explicitely save and restore it or X might get upset. I'll have a look.
> >
> > Actually, subsystem stuff is below 0x40 so it should be fine too.
>
> The things above 0x40 tend to be:
>
> - capabilities (values and next-pointers)
>
> The PCI layer will save a random couple of these (read: the ones it
> cares about)
>
> - random non-architected values specific to that chip. And sometimes
> these are important. Like ISA interrupt routing information for cardbus
> controllers. Or timing values set up by the BIOS.

Right, I've seen such things, but in our case, all the radeons I support
in there should be ok with just 64 bytes.

Cheers,
Ben.