Re: Reworking suspend-resume sequence (was: Re: PCI PM: Restore standard config registers of all devices early)

Linus Torvalds
2009-02-03T23:19:26Z

On Wed, 4 Feb 2009, Benjamin Herrenschmidt wrote:
>
> Wait wait wait ... the -whole- point of the exercise, wether using
> local_irq_save or disable_irq, -is- to put the ACPI bit -after- setting
> the device in low power state and before the restore on wakeup...

You're missing context.

ACPI isn't just for the device power settings. It's for the CPU's too, and
it's for things like "prepare to sleep". And they all have _different_
requirements.

What Rafael is trying to tell you is that we have ACPI-initiated ordering
requirements between turning CPU's off, and turning devices off, and he's
not willing to change that.

> The -one- thing that indeed conflicts here is that we disable nonboot
> CPUs earlier. Right ?

This.

> Now, I doubt that would be a big issue

With ACPI, there is no such thing as a "big issue". There are only tons of
small horrid details that. And the "big issue" is that all the small
details are insane.

Linus