Re: PCI PM: Restore standard config registers of all devices early

Linus Torvalds
2009-02-02T20:42:19Z

On Tue, 3 Feb 2009, Benjamin Herrenschmidt wrote:
>
> I'd rather hook it up inside pci_set_power_state()...

Umm. But you already _have_ that. Look at platform_pci_set_power_state().
It gets called before turning the device on (pci_raw_set_power_state(D0))
and after turning the device off (pci_raw_set_power_state(D1+))

Maybe you missed it? It's how ACPI does things.

However, the issue you see is that pci_restore_standard_config() doesn't
call it, because at least with ACPI, the ACPI code simply isn't ready to
be called with interrupts off. So it looks like you may be looking at the
wrong thing, hmm?

Linus