From: Rogier Wolff <R.E.Wolff@BitWizard.nl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dan Carpenter <error27@gmail.com>,
R.E.Wolff@BitWizard.nl, linux-kernel@vger.kernel.org
Subject: Re: [patch] unlock_kernel() on error path in sx_fw_ioctl()
Date: Wed, 4 Feb 2009 10:49:13 +0100 [thread overview]
Message-ID: <20090204094913.GB23618@bitwizard.nl> (raw)
In-Reply-To: <20090203205857.a2b4b1c1.akpm@linux-foundation.org>
On Tue, Feb 03, 2009 at 08:58:57PM -0800, Andrew Morton wrote:
> fix another such path - missed func_exit().
This is not critical. It's just debug. When DEBUG_CALLS (or something
like that) is active, it will print "leaving function ... ".
Indeed if it's missing, you might start to think why DID it return,
but not print the message... or. howcome it's still in that function
doing stuff that isn't there. Anyway, looking into it would provide
you more info that it was returning the error.....
Anyway, nice to clean it up "while we're at it".
Roger.
--
** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2600998 **
** Delftechpark 26 2628 XH Delft, The Netherlands. KVK: 27239233 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
Q: It doesn't work. A: Look buddy, doesn't work is an ambiguous statement.
Does it sit on the couch all day? Is it unemployed? Please be specific!
Define 'it' and what it isn't doing. --------- Adapted from lxrbot FAQ
prev parent reply other threads:[~2009-02-04 9:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 8:14 [patch] unlock_kernel() on error path in sx_fw_ioctl() Dan Carpenter
2009-02-04 4:58 ` Andrew Morton
2009-02-04 9:49 ` Rogier Wolff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090204094913.GB23618@bitwizard.nl \
--to=r.e.wolff@bitwizard.nl \
--cc=akpm@linux-foundation.org \
--cc=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox