From: Frans Pop <elendil@planet.nl>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: Frank Seidel <fseidel@suse.de>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org,
len.brown@intel.com, shaohuhua.li@intel.com,
kristen.c.accardi@intel.com, frank@f-seidel.de
Subject: Re: [PATCH] ACPI: add missing KERN_* constants to printks
Date: Wed, 4 Feb 2009 17:12:57 +0100 [thread overview]
Message-ID: <200902041713.00301.elendil@planet.nl> (raw)
In-Reply-To: <alpine.LRH.2.00.0902041642450.7690@vixen.sonytel.be>
On Wednesday 04 February 2009, Geert Uytterhoeven wrote:
> > This patch looks broken to me, at least for some of your changes.
> > For example, in the bit quoted above all printks together make up
> > *one single* message, which means that only the _first_ of the
> > printks should have the KERN_* prefix. printks that are continuations
> > should not have the prefix.
>
> Actually they should, but the right prefix :-)
Hmm. I was going by memory and from what I've seen in existing code, but
also found this (somewhat old) post:
https://lists.linux-foundation.org/pipermail/kernel-janitors/2005-October/014375.html
> Quoting include/linux/kernel.h:
> | /*
> | * Annotation for a "continued" line of log printout (only done after a
> | * line that had no enclosing \n). Only to be used by core/arch code
> | * during early bootup (a continued line is not SMP-safe otherwise).
> | */
> | #define KERN_CONT ""
>
> Please also consider the note about SMP-safeness.
>From that it looks like KERN_CONT should only be used in a very limited
context, but I guess this example qualifies.
next prev parent reply other threads:[~2009-02-04 16:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 14:34 [PATCH] ACPI: add missing KERN_* constants to printks Frank Seidel
2009-02-04 15:28 ` Frans Pop
2009-02-04 15:31 ` Frank Seidel
2009-02-04 15:44 ` Geert Uytterhoeven
2009-02-04 15:48 ` Frank Seidel
2009-02-04 16:12 ` Frans Pop [this message]
2009-02-04 16:48 ` Geert Uytterhoeven
2009-02-04 16:03 ` [PATCHv2] " Frank Seidel
2009-02-07 5:38 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902041713.00301.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=akpm@linux-foundation.org \
--cc=frank@f-seidel.de \
--cc=fseidel@suse.de \
--cc=kristen.c.accardi@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=shaohuhua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox