From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com,
Containers <containers@lists.osdl.org>,
hch@lst.de, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [v2][PATCH 1/5] Unroll essentials of do_remount_sb() into devpts
Date: Wed, 4 Feb 2009 18:27:57 -0600 [thread overview]
Message-ID: <20090205002757.GA18758@us.ibm.com> (raw)
In-Reply-To: <20090204234905.GB17354@us.ibm.com>
Quoting Serge E. Hallyn (serue@us.ibm.com):
> Quoting Sukadev Bhattiprolu (sukadev@linux.vnet.ibm.com):
> >
> > From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> > Date: Tue, 27 Jan 2009 22:58:18 -0800
> > Subject: [v2][PATCH 1/5] Unroll essentials of do_remount_sb() into devpts
> >
> > On remount, devpts fs only needs to parse the mount options. Users cannot
> > directly create/dirty files in /dev/pts so the MS_RDONLY flag and
> > shrinking the dcache does not really apply to devpts.
> >
> > So effectively on remount, devpts only parses the mount options and updates
> > these options in its super block. As such, we could replace do_remount_sb()
> > call with a direct parse_mount_options().
> >
> > Doing so enables subsequent patches to avoid parsing the mount options twice
> > and simplify the code.
>
> You've dropped the update_ptmx_mode() which you used to do
> inside devpts_remount(). Is that also on purpose?
Since it appears that mknod_ptmx() will be called anyway and
will do the same thing,
> > Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
next prev parent reply other threads:[~2009-02-05 0:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 4:35 [PATCH 0/5][v2] Simplify devpts code Sukadev Bhattiprolu
2009-02-04 4:36 ` [v2][PATCH 1/5] Unroll essentials of do_remount_sb() into devpts Sukadev Bhattiprolu
2009-02-04 23:49 ` Serge E. Hallyn
2009-02-05 0:27 ` Serge E. Hallyn [this message]
2009-02-04 4:37 ` [v2][PATCH 2/5] Parse mount options just once and copy them to super block Sukadev Bhattiprolu
2009-02-05 0:10 ` Serge E. Hallyn
2009-03-07 17:31 ` Sukadev Bhattiprolu
2009-02-04 4:37 ` [v2][PATCH 3/5] Move common mknod_ptmx() calls into caller Sukadev Bhattiprolu
2009-02-05 0:26 ` Serge E. Hallyn
2009-02-04 4:37 ` [v2][PATCH 4/5] Remove get_init_pts_sb() Sukadev Bhattiprolu
2009-02-05 1:07 ` Serge E. Hallyn
2009-02-04 4:38 ` [v2][PATCH 5/5] Merge code for single and multiple-instance mounts Sukadev Bhattiprolu
2009-02-06 18:51 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205002757.GA18758@us.ibm.com \
--to=serue@us.ibm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=containers@lists.osdl.org \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox