From: Andrew Morton <akpm@linux-foundation.org>
To: Phillip Lougher <phillip@lougher.demon.co.uk>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
snakebyte@gmx.de, sliedes@cc.hut.fi, phillip@lougher.demon.co.uk
Subject: Re: [PATCH] Squashfs: Fix oops when reading fsfuzzer corrupted filesystems
Date: Thu, 5 Feb 2009 12:22:15 -0800 [thread overview]
Message-ID: <20090205122215.adcd18db.akpm@linux-foundation.org> (raw)
In-Reply-To: <E1LUY7A-0006q4-LB@dylan.lougher.demon.co.uk>
On Wed, 04 Feb 2009 03:07:48 +0000
Phillip Lougher <phillip@lougher.demon.co.uk> wrote:
> - ERROR("sb_bread failed reading block 0x%llx\n", cur_index);
> + ERROR("squashfs_read_data failed to read block 0x%llx\n", index);
`index' has type u64. You don't know what C type is used to implement
u64, hence it must be cast to a known type before it can be passed to
printk.
In this case we use `unsigned long long'.
The code as it stands will generate compiler warnings on some
architectures.
One day, maybe before we all die, we will fix this. Then we get to
spend another five years weeding out all the casts we added.
next prev parent reply other threads:[~2009-02-05 20:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 3:07 [PATCH] Squashfs: Fix oops when reading fsfuzzer corrupted filesystems Phillip Lougher
2009-02-05 20:22 ` Andrew Morton [this message]
2009-02-06 0:58 ` Phillip Lougher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205122215.adcd18db.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@lougher.demon.co.uk \
--cc=sliedes@cc.hut.fi \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox