From: Andrew Morton <akpm@linux-foundation.org>
To: Bryan Wu <cooloney@kernel.org>
Cc: dbrownell@users.sourceforge.net,
spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org, michael.hennerich@analog.com,
cooloney@kernel.org
Subject: Re: [PATCH 4/5] Blackfin SPI Driver: Add GPIO controlled SPI Slave Select support
Date: Thu, 5 Feb 2009 14:12:55 -0800 [thread overview]
Message-ID: <20090205141255.2009f858.akpm@linux-foundation.org> (raw)
In-Reply-To: <1233828453-13311-5-git-send-email-cooloney@kernel.org>
On Thu, 5 Feb 2009 18:07:32 +0800
Bryan Wu <cooloney@kernel.org> wrote:
>
> This patch adds support for GPIO controlled SPI Chip Selects.
> To make use of this feature, set chip_select = 0 and add a proper
> cs_gpio to your controller_data.
>
> struct spi_board_info
> .chip_select = 0
>
> struct bfin5xx_spi_chip
> .cs_gpio = GPIO_P###
>
> There are various SPI devices that require SPI MODE_0,
> and need to have the Chip Selects asserted during the entire transfer.
> Consider using SPI_MODE_3 (SPI_CPHA | SPI_CPOL) if your device allows
> it.
Cannot apply this due to previously-mentioned driver-core-tramplings.
next prev parent reply other threads:[~2009-02-05 22:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 10:07 [PATCH 0/5] Blackfin SPI Driver updates Bryan Wu
2009-02-05 10:07 ` [PATCH 1/5] Blackfin SPI Driver: use bfin_spi_ prefix on all functions Bryan Wu
2009-02-05 22:12 ` Andrew Morton
2009-02-06 2:26 ` Bryan Wu
2009-02-06 2:34 ` Stephen Rothwell
2009-02-06 2:47 ` Andrew Morton
2009-02-05 10:07 ` [PATCH 2/5] Blackfin SPI Driver: add comment about full duplex dma according to David Brownell Bryan Wu
2009-02-05 10:07 ` [PATCH 3/5] Blackfin SPI Driver: fix NULL pointer crash Bryan Wu
2009-02-05 22:12 ` Andrew Morton
2009-02-05 22:29 ` Mike Frysinger
2009-02-05 10:07 ` [PATCH 4/5] Blackfin SPI Driver: Add GPIO controlled SPI Slave Select support Bryan Wu
2009-02-05 22:12 ` Andrew Morton [this message]
2009-02-05 10:07 ` [PATCH 5/5] Blackfin SPI Driver: Make mmc_spi driver work on Blackfin Bryan Wu
2009-02-05 22:13 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205141255.2009f858.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cooloney@kernel.org \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox