From: Oleg Nesterov <oleg@redhat.com>
To: Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jerome Marchand <jmarchan@redhat.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] ptrace: fix possible zombie leak on PTRACE_DETACH
Date: Thu, 5 Feb 2009 15:41:35 +0100 [thread overview]
Message-ID: <20090205144135.GB20953@redhat.com> (raw)
In-Reply-To: <20090205013042.C833EFC381@magilla.sf.frob.com>
On 02/04, Roland McGrath wrote:
>
> ACK on the change, though looks different if you put __ptrace_detach in
> ptrace.c with the earliar patch, as I suggest. Also, I think this warrants
> a comment for the release_task call mentioning briefly what it means:
>
> /*
> * The flag means __ptrace_detach() determined that this child
> * was a zombie that should have been auto-reaped already.
> * Don't leak it.
> */
> if (unlikely(dead))
> release_task(child);
OK, will add this to the cleanup patch too.
Oleg.
prev parent reply other threads:[~2009-02-05 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 4:29 [PATCH 4/4] ptrace: fix possible zombie leak on PTRACE_DETACH Oleg Nesterov
2009-02-05 1:30 ` Roland McGrath
2009-02-05 14:41 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205144135.GB20953@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dvlasenk@redhat.com \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox