From: Greg KH <greg@kroah.com>
To: Frank Seidel <fseidel@suse.de>
Cc: linux kernel <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org, jbarnes@virtuousgeek.org,
kristen.c.accardi@intel.com, ashok.raj@intel.com,
shaohua.li@intel.com, anil.s.keshavamurthy@intel.com,
fenghua.yu@intel.com, akpm@linux-foundation.org,
frank@f-seidel.de, Frans Pop <elendil@planet.nl>,
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Subject: Re: [PATCH] PCI: add missing KERN_* constants to printks
Date: Thu, 5 Feb 2009 09:28:59 -0800 [thread overview]
Message-ID: <20090205172859.GA20558@kroah.com> (raw)
In-Reply-To: <498B2116.6010707@suse.de>
On Thu, Feb 05, 2009 at 06:25:42PM +0100, Frank Seidel wrote:
> From: Frank Seidel <frank@f-seidel.de>
>
> According to kerneljanitors todo list all printk calls (beginning
> a new line) should have an according KERN_* constant.
> Those are the missing pieces here for the pci subsystem.
>
> Signed-off-by: Frank Seidel <frank@f-seidel.de>
> ---
> drivers/pci/hotplug/pciehp_core.c | 6 +++---
> drivers/pci/hotplug/shpchp_core.c | 4 ++--
> drivers/pci/intel-iommu.c | 2 +-
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> --- a/drivers/pci/hotplug/pciehp_core.c
> +++ b/drivers/pci/hotplug/pciehp_core.c
> @@ -526,16 +526,16 @@ static int __init pcied_init(void)
>
> pciehp_firmware_init();
> retval = pcie_port_service_register(&hpdriver_portdrv);
> - dbg("pcie_port_service_register = %d\n", retval);
> + dbg(KERN_DEBUG "pcie_port_service_register = %d\n", retval);
dbg() already sets the KERN_ level, right?
thanks,
greg k-h
next prev parent reply other threads:[~2009-02-05 17:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 17:25 [PATCH] PCI: add missing KERN_* constants to printks Frank Seidel
2009-02-05 17:28 ` Greg KH [this message]
2009-02-05 17:32 ` Frank Seidel
2009-02-05 17:36 ` Frank Seidel
2009-02-05 17:49 ` Greg KH
2009-02-05 18:01 ` Frank Seidel
2009-02-05 18:02 ` [PATCHv2] " Frank Seidel
2009-02-06 8:04 ` Kenji Kaneshige
2009-02-06 8:07 ` Frank Seidel
2009-02-06 8:57 ` Kenji Kaneshige
2009-02-06 9:01 ` Taku Izumi
2009-02-06 9:16 ` Frank Seidel
2009-02-06 10:23 ` Geert Uytterhoeven
2009-02-06 9:23 ` [PATCHv3] " Frank Seidel
2009-02-09 6:47 ` Kenji Kaneshige
2009-02-13 21:16 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205172859.GA20558@kroah.com \
--to=greg@kroah.com \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=akpm@linux-foundation.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=ashok.raj@intel.com \
--cc=elendil@planet.nl \
--cc=fenghua.yu@intel.com \
--cc=frank@f-seidel.de \
--cc=fseidel@suse.de \
--cc=jbarnes@virtuousgeek.org \
--cc=kristen.c.accardi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox