public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Tony Luck <tony.luck@intel.com>,
	Jaswinder Singh Rajput <jaswinder@kernel.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	hskinnemoen@atmel.com, cooloney@kernel.org, ralf@linux-mips.org,
	dhowells@redhat.com, matthew@wil.cx, chris@zankel.net,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull -tip] headers_check fixes for other architectures
Date: Thu, 5 Feb 2009 20:19:07 +0100	[thread overview]
Message-ID: <20090205191907.GA27422@elte.hu> (raw)
In-Reply-To: <alpine.LFD.2.00.0902051101040.3247@localhost.localdomain>


* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Thu, 5 Feb 2009, Tony Luck wrote:
> > 
> > Either revert this part ... or wrap the #include like this in fpu.h:
> > 
> > #ifndef __ASSEMBLY__
> > #include <linux/types.h>
> > #endif
> 
> That loses the
> 
> 	arch/ia64/include/asm/types.h:# define __IA64_UL(x)             (x)
> 
> thing from <asm/types.h>, and makes some of the constants unusable from 
> asm. Maybe nobody cares.
> 
> But it looks like that core really needs to use <asm/types.h> right now.

Note that these bits are not mainline yet, they are still being refined.

Jaswinder, because they can break the build we should proactively drop all 
architecture patches that do asm/types.h conversions.

I did build all the affected architectures via their defconfigs and they 
built just fine - but i cannot do wide coverage testing of them.

So i think we should drop these bits:

 earth4:~/tip> gll --grep='asm/types.h' linus..core/header-fixes
 1ff8f73: headers_check fix: xtensa, swab.h
 4810987: headers_check fix: powerpc, swab.h
 9f2cd96: headers_check fix: powerpc, kvm.h
 785857f: headers_check fix: powerpc, elf.h
 4be2c7f: headers_check fix: powerpc, bootx.h
 726da1e: headers_check fix: parisc, swab.h
 bef53ca: headers_check fix: mn10300, swab.h
 a9f6acc: headers_check fix: mips, swab.h
 d8cbec1: headers_check fix: m32r, swab.h
 040c92b: headers_check fix: ia64, swab.h
 6ce7950: headers_check fix: ia64, kvm.h
 fa9ea6c: headers_check fix: ia64, fpu.h
 295803e: headers_check fix: h8300, swab.h
 dacd762: headers_check fix: frv, swab.h
 350eb8b: headers_check fix: blackfin, swab.h
 1c6ce70: headers_check fix: avr32, swab.h
 e42ec24: headers_check fix: arm, swab.h
 4af3bf6: headers_check fix: arm, setup.h
 f100e6d: headers_check fix: arm, a.out.h
 3fd5906: headers_check fix: alpha, swab.h

and send the rest to Linus if all outstanding observations have been 
addressed. What do you think?

	Ingo

  reply	other threads:[~2009-02-05 19:19 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-31  7:10 [git pull -tip] headers_check fixes for other architectures Jaswinder Singh Rajput
2009-01-31 16:44 ` Ingo Molnar
2009-02-01  6:30   ` Jaswinder Singh Rajput
2009-02-01 10:39     ` Ingo Molnar
2009-02-01 16:49       ` Ingo Molnar
2009-02-01 17:06         ` Russell King - ARM Linux
2009-02-01 17:20         ` Russell King - ARM Linux
2009-02-01 17:31           ` Jaswinder Singh Rajput
2009-02-01 18:33         ` Jaswinder Singh Rajput
2009-02-02 17:11         ` Mike Frysinger
2009-02-02 18:08           ` Ingo Molnar
2009-02-02 18:29             ` Mike Frysinger
2009-02-02 18:48               ` Ingo Molnar
2009-02-05 17:55 ` Tony Luck
2009-02-05 19:06   ` Linus Torvalds
2009-02-05 19:19     ` Ingo Molnar [this message]
2009-02-06  2:06       ` Jaswinder Singh Rajput
2009-02-06  2:14         ` Mike Frysinger
2009-02-06  2:20         ` Ingo Molnar
2009-02-06 14:18           ` Jaswinder Singh Rajput
2009-02-06 14:21             ` Russell King - ARM Linux
2009-02-06 14:34               ` Jaswinder Singh Rajput
2009-02-06 14:51                 ` Russell King - ARM Linux
2009-02-06 14:58                   ` Ingo Molnar
2009-02-06 15:00                   ` Jaswinder Singh Rajput
2009-02-06 15:10                     ` Russell King - ARM Linux
2009-02-06 15:56                       ` Ingo Molnar
2009-02-06 16:02                         ` Russell King - ARM Linux
2009-02-06 17:24             ` Sam Ravnborg
2009-02-06 17:40               ` Ingo Molnar
2009-02-06 18:11               ` Jaswinder Singh Rajput
2009-02-06 18:42                 ` Sam Ravnborg
2009-02-06 19:31                   ` Jaswinder Singh Rajput
2009-02-08  5:50               ` Jaswinder Singh Rajput
2009-02-09 12:23                 ` Ingo Molnar
2009-02-06  8:19 ` [linux-next][PATCH] revert headers_check fix: ia64, fpu.h KOSAKI Motohiro
2009-02-06  8:53   ` Jaswinder Singh Rajput
2009-02-06  9:11     ` KOSAKI Motohiro
2009-02-06 14:55       ` Ingo Molnar
2009-02-06 15:29         ` Jaswinder Singh Rajput
2009-02-06 15:33           ` Russell King - ARM Linux
2009-02-06 15:45             ` Ingo Molnar
2009-02-06 15:49               ` Russell King - ARM Linux
2009-02-06 16:01                 ` Ingo Molnar
2009-02-06 15:48             ` Jaswinder Singh Rajput
2009-02-06 15:55               ` Russell King - ARM Linux
2009-02-06 16:12                 ` Ingo Molnar
2009-02-06 16:23                   ` Russell King - ARM Linux
2009-02-06 16:33                     ` Ingo Molnar
2009-02-06 16:38                       ` Russell King - ARM Linux
2009-02-06 17:14                         ` Ingo Molnar
2009-02-06 17:22                           ` Russell King - ARM Linux
2009-02-06 17:32                 ` Sam Ravnborg
2009-02-06 17:41                   ` Ingo Molnar
2009-02-06 18:53     ` Luck, Tony
2009-02-06 13:42   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090205191907.GA27422@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=chris@zankel.net \
    --cc=cooloney@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=hskinnemoen@atmel.com \
    --cc=jaswinder@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=matthew@wil.cx \
    --cc=ralf@linux-mips.org \
    --cc=sam@ravnborg.org \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox