From: Frans Pop <elendil@planet.nl>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au
Subject: Re: PATCH: Allow user to force 'tsc' to be treated as stable.
Date: Thu, 5 Feb 2009 22:18:45 +0100 [thread overview]
Message-ID: <200902052218.46235.elendil@planet.nl> (raw)
In-Reply-To: <498B42C5.7010905@candelatech.com>
Ben Greear wrote:
> + if (force_tsc_stable && (strcmp(cs->name, "tsc") == 0))
> + printk(KERN_WARNING "Forcing tsc to be treated as stable due to force_tsc_stable=1\n");
> + else {
> + printk(KERN_WARNING " This clock is no longer valid for WATCHDOG or HIGH-RES.\n");
> + if (strcmp(cs->name, "tsc") == 0)
> + printk(KERN_WARNING " Use force_tsc_stable=1 to override.\n");
Do we really want to be so verbose?
Loads of users get these messages (I get it on both my laptops) and IIUC
the workaround is only valid for a very limited group of users.
I'd suggest dropping the "else" branch. It seems inadvisable to encourage
workarounds that may not be valid (or even safe).
Cheers,
FJP
next prev parent reply other threads:[~2009-02-05 21:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 19:49 PATCH: Allow user to force 'tsc' to be treated as stable Ben Greear
2009-02-05 19:59 ` Ingo Molnar
2009-02-05 20:38 ` Ben Greear
2009-02-05 21:02 ` Ingo Molnar
2009-02-05 21:18 ` Frans Pop [this message]
2009-02-06 14:36 ` Jiri Kosina
2009-02-06 17:52 ` Ben Greear
2009-02-06 19:40 ` Thomas Gleixner
2009-02-06 23:24 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902052218.46235.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=greearb@candelatech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox