From: Oliver Neukum <oliver@neukum.org>
To: "Dirk DeSchepper" <ddeschepper@nvtl.com>,
USB development list <linux-usb@vger.kernel.org>
Cc: "Greg KH" <greg@kroah.com>,
smurf@smurf.noris.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 001/001] usbserial: New mobile broadband modems to be supported through option module
Date: Fri, 6 Feb 2009 12:58:39 +0100 [thread overview]
Message-ID: <200902061258.40303.oliver@neukum.org> (raw)
In-Reply-To: <B29F014DE7B1F949B0BC4C1EBCF29DD6C6D2A3@Vectra.nvtl.local>
Am Friday 06 February 2009 12:29:06 schrieb Dirk DeSchepper:
> From: Dirk De Schepper <ddeschepper@nvtl.com>
>
> Patch for option.c, based on kernel v2.6.28.3
> - New Novatel and Dell mobile broadband modem products added
> - Dell pid variables used in stead of numerical PIDs for known products
This is not really an advantage. You usually get the nummeric IDs
just fine from lsusb. And you could easily see the nummeric order of entries.
These symbolic names do not appear in code, just in the macros
where their meaning is clear. You introduce a useless level of indirection.
Regards
Oliver
next prev parent reply other threads:[~2009-02-06 11:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <12047829252365@kroah.org>
[not found] ` <B29F014DE7B1F949B0BC4C1EBCF29DD6C6D1E0@Vectra.nvtl.local>
[not found] ` <20090206003352.GA22530@kroah.com>
2009-02-06 11:29 ` [PATCH 001/001] usbserial: New mobile broadband modems to be supported through option module Dirk DeSchepper
2009-02-06 11:58 ` Oliver Neukum [this message]
2009-02-06 18:51 ` Greg KH
2009-02-06 19:23 ` Oliver Neukum
2009-02-06 23:47 ` Greg KH
2009-02-07 9:03 ` Oliver Neukum
2009-02-06 18:52 ` Greg KH
2009-02-06 20:48 ` [PATCH 001/001] usbserial: New mobile broadband modems to besupported " Dirk DeSchepper
2009-02-07 1:11 ` patch usb-option-new-mobile-broadband-modems-to-be-supported.patch added to gregkh-2.6 tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902061258.40303.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=ddeschepper@nvtl.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=smurf@smurf.noris.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox