From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755369AbZBFM65 (ORCPT ); Fri, 6 Feb 2009 07:58:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753400AbZBFM6s (ORCPT ); Fri, 6 Feb 2009 07:58:48 -0500 Received: from relay3.sgi.com ([192.48.171.31]:38210 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753299AbZBFM6r (ORCPT ); Fri, 6 Feb 2009 07:58:47 -0500 Date: Fri, 6 Feb 2009 06:58:45 -0600 From: Robin Holt To: Andrea Arcangeli , Andrew Morton Cc: Christoph Lameter , Robin Holt , linux-mm@kvack.org, Nick Piggin , linux-kernel@vger.kernel.org Subject: Re: [Patch] mmu_notifiers destroyed by __mmu_notifier_release() retain extra mm_count. Message-ID: <20090206125845.GC8559@sgi.com> References: <20090205172303.GB8559@sgi.com> <20090205200214.GN8577@sgi.com> <20090206013805.GL14011@random.random> <20090206014400.GM14011@random.random> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090206014400.GM14011@random.random> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 06, 2009 at 02:44:00AM +0100, Andrea Arcangeli wrote: > simply. For a moment I thought unregister wasn't mandatory because at > some point in one of the dozen versions of the api it wasn't, but in You are right, I am remembering an older version of the API (which I still like better, obviously ;) ). I also see the problems each choice of API can cause. I think the current API is the more reasonable choice. I have adjusted XPMEM to keep a copy of the mm_struct pointer at register time with my own accompanying inc of mm_count and likewise do the unregister and mmdrop(); This resolved my problem. Sorry for the noise. Andrew, could you throw this patch as away as quickly as possible. Sorry for wasting your time. Thanks, Robin