Re: [PATCH 0/6] fix PASIC3/DS1WM, use MFD core

[Samuel Ortiz <sameo@openedhand.com>]

Hi Philipp,

On Thu, Feb 05, 2009 at 05:53:34PM +0100, Philipp Zabel wrote:
> Hi,
> 
> the following patches turn DS1WM into an MFD cell driver, make PASIC3 use 
> the MFD core functions to register it and remove the generic clock API
> code from DS1WM as MFDs currently can't register their clocks with it.
> With those applied, 1-Wire is finally in a working state on magician.
> 
> Patch #2 depends on #1, patch #4 depends on #3 and patch #6 depends on #5.
> Therefor I propose that this whole patchset be queued in the mfd tree.
> If so, #4 could be merged into #2. But it won't hurt to just leave out 
> #3 and #4 for now and apply them as cleanups later.
The patches look good to me. I'll merge the 6 of them into my for-next branch.

Thanks for this work.

Cheers,
Samuel.


> Philipp Zabel (6):
>       mfd: DS1WM: convert to use MFD core
>       mfd: PASIC3: convert to use MFD core
>       pxa/magician: remove deprecated .bus_shift from PASIC3 platform_data
>       mfd: PASIC3: remove unused bus_shift field
>       mfd: DS1WM: remove clock handling
>       mfd: PASIC3: supply clock_rate to DS1WM via driver_data
> 
>  arch/arm/mach-pxa/magician.c   |    1 -
>  drivers/mfd/Kconfig            |    1 +
>  drivers/mfd/htc-pasic3.c       |  169 ++++++++++++++++------------------------
>  drivers/w1/masters/ds1wm.c     |   53 ++++++-------
>  include/linux/ds1wm.h          |   12 ---
>  include/linux/mfd/ds1wm.h      |    6 ++
>  include/linux/mfd/htc-pasic3.h |    1 -
>  7 files changed, 100 insertions(+), 143 deletions(-)
>  delete mode 100644 include/linux/ds1wm.h
>  create mode 100644 include/linux/mfd/ds1wm.h

-- 
Intel Open Source Technology Centre
http://oss.intel.com/