From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758017AbZBFPd4 (ORCPT ); Fri, 6 Feb 2009 10:33:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751368AbZBFPds (ORCPT ); Fri, 6 Feb 2009 10:33:48 -0500 Received: from fg-out-1718.google.com ([72.14.220.153]:60477 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750699AbZBFPdr (ORCPT ); Fri, 6 Feb 2009 10:33:47 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=qRM7d60LdDl4KU1fFNqczAEd3dZqTrCaqSqAqAVO7NDHe3K7wFUC/A98nAmFea0dij X7glUXNXzZlLwoYlsqdba4kn19CIfMkq8MIsT5pC03aEgZPtYb4MbLrqNYKNyM217+Fq QjvYFu49uEEwLe1LWihkAZNmamccgr1cnWtFg= Date: Fri, 6 Feb 2009 16:33:42 +0100 From: Frederic Weisbecker To: Ingo Molnar Cc: Steven Rostedt , Peter Zijlstra , linux-kernel@vger.kernel.org, Andrew Morton , Steven Rostedt , Mathieu Desnoyers Subject: Re: [PATCH 2/4] nmi: add generic nmi tracking state Message-ID: <20090206153340.GA5033@nowhere> References: <20090206065352.940088243@goodmis.org> <20090206065437.986292747@goodmis.org> <1233912891.4731.1.camel@laptop> <20090206144609.GB18368@elte.hu> <20090206145431.GG18368@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090206145431.GG18368@elte.hu> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 06, 2009 at 03:54:31PM +0100, Ingo Molnar wrote: > > * Steven Rostedt wrote: > > > On Fri, 6 Feb 2009, Ingo Molnar wrote: > > > > > > > > * Peter Zijlstra wrote: > > > > > > > On Fri, 2009-02-06 at 01:53 -0500, Steven Rostedt wrote: > > > > > > > > > This code adds an in_nmi() macro that uses the current tasks preempt count > > > > > to track when it is in NMI context. Other parts of the kernel can > > > > > use this to determine if the context is in NMI context or not. > > > > > > > > > > This code was inspired by the -rt patch in_nmi version that was > > > > > written by Peter Zijlstra. > > > > > > > > Which in turn I borrowed from Mathieu. > > > > > > Steve, could you please fix the attribution? > > > > Is it OK to rebase the branch to do so? > > Sure, that's necessary. > > And note that unless you base your tree against tip:tracing/ftrace i cannot > do a straight pull anyway. (your trees are usually based against tip:master > - which brings in all other branches) Oh really? I always base my tracing patches against tip/master, assuming tracing/ftrace is about always quickly merged into master. But the opposite is not necessarily true, I guess you don't merge master into tracing/ftrace so quickly to not break the history right? And I guess it's better to catch bugs if each individual topics is not too quickly synced against tip/master. > Ingo