From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758228AbZBFT0u (ORCPT ); Fri, 6 Feb 2009 14:26:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752948AbZBFT0k (ORCPT ); Fri, 6 Feb 2009 14:26:40 -0500 Received: from ns1.siteground211.com ([209.62.36.12]:60103 "EHLO serv01.siteground211.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752822AbZBFT0k (ORCPT ); Fri, 6 Feb 2009 14:26:40 -0500 Date: Fri, 6 Feb 2009 21:26:30 +0200 From: Felipe Balbi To: Mike Frysinger Cc: me@felipebalbi.com, Bryan Wu , felipe.balbi@nokia.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: musb: tweak musb_read_fifo() to avoid unused warnings Message-ID: <20090206192629.GE10711@frodo> Reply-To: me@felipebalbi.com References: <1233915736-18506-1-git-send-email-cooloney@kernel.org> <20090206191558.GD10711@frodo> <8bd0f97a0902061124s3c44d39dmf306a44f0c16528d@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8bd0f97a0902061124s3c44d39dmf306a44f0c16528d@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - serv01.siteground211.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - felipebalbi.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 06, 2009 at 02:24:27PM -0500, Mike Frysinger wrote: > On Fri, Feb 6, 2009 at 14:15, Felipe Balbi wrote: > > On Fri, Feb 06, 2009 at 06:22:16PM +0800, Bryan Wu wrote: > >> From: Mike Frysinger > > > > I'd like to get a patch body here. > > > >> Signed-off-by: Mike Frysinger > >> Signed-off-by: Bryan Wu > >> --- > >> drivers/usb/musb/blackfin.c | 9 +++++---- > >> 1 files changed, 5 insertions(+), 4 deletions(-) > >> > >> diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb/musb/blackfin.c > >> index 7861348..0ebb19d 100644 > >> --- a/drivers/usb/musb/blackfin.c > >> +++ b/drivers/usb/musb/blackfin.c > >> @@ -54,13 +54,11 @@ void musb_write_fifo(struct musb_hw_ep *hw_ep, u16 len, const u8 *src) > >> void musb_read_fifo(struct musb_hw_ep *hw_ep, u16 len, u8 *dst) > >> { > >> void __iomem *fifo = hw_ep->fifo; > >> + > >> +#ifdef CONFIG_BF52x > >> u8 epnum = hw_ep->epnum; > >> u16 dma_reg = 0; > > > > Is this patch avoiding a warning about these variables being unused ? > > > > Would be nice to get this info to the patch body ;-) > > the subject already says that the subject says: "tweak musb_read_fifo() to avoid unused warnings" it doesn't specify where are the warnings. -- balbi