From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, rpurdie@rpsys.net, mingo@elte.hu,
tglx@linutronix.de, hpa@zytor.com
Subject: Re: [PATCH] Soekris net5501 board support code
Date: Sat, 7 Feb 2009 00:35:22 +0100 [thread overview]
Message-ID: <20090207003522.32049f4f@i1501.lan.towertech.it> (raw)
In-Reply-To: <20090206152121.3ae5208a.akpm@linux-foundation.org>
On Fri, 6 Feb 2009 15:21:21 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:
> > + rombase = ioremap(0xffff0000, 0xffff);
> > + if (!rombase)
> > + return 0;
>
> Is it appropriate to silently "succeed" if the ioremap() failed?
maybe not.. I'll add a printk. ty.
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
next prev parent reply other threads:[~2009-02-06 23:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 15:13 [PATCH] Soekris net5501 board support code Alessandro Zummo
2009-02-06 23:21 ` Andrew Morton
2009-02-06 23:35 ` Alessandro Zummo [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-12-26 1:26 Alessandro Zummo
2008-12-27 0:41 ` Andrew Morton
2008-12-27 0:55 ` H. Peter Anvin
2008-12-27 1:41 ` Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090207003522.32049f4f@i1501.lan.towertech.it \
--to=alessandro.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rpurdie@rpsys.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox