Re: [PATCH 6/7] Ksplice: Export symbols needed for Ksplice

Rusty Russell
2009-02-16T07:11:45Z

On Friday 13 February 2009 12:16:40 Tim Abbott wrote:
> On Wed, 4 Feb 2009, Rusty Russell wrote:
>
> > On Saturday 06 December 2008 10:33:59 Jeff Arnold wrote:
> > > From: Tim Abbott <tabbott@mit.edu>
> > >
> > > Ksplice uses several functions from module.c in order to resolve
> > > symbols and implement dependency handling. Calling these functions
> > > requires holding module_mutex, so it is exported.
> >
> > I have fought every attempt to export that. It was long a cause of misery
> > and pain; people saw the lock and so started grabbing it.
> >
> > Any chance we can find another way?
>
> It is definitely possible, but it wouldn't be pretty. There are a few
> things that we use module_mutex for:

Yes, having looked through the code I don't think the export can be avoided.

Thanks,
Rusty.