From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754420AbZBGWQP (ORCPT ); Sat, 7 Feb 2009 17:16:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752346AbZBGWP7 (ORCPT ); Sat, 7 Feb 2009 17:15:59 -0500 Received: from fg-out-1718.google.com ([72.14.220.153]:12036 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752271AbZBGWP6 (ORCPT ); Sat, 7 Feb 2009 17:15:58 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=LYeuMn8xMbiMenYDHeS+KENyVAM73ekIcmOiMdUN7tEMZe5Lh6DcaSN7RVsnw194Bw DaCehWqMuE/naXCkb1LZTW6zay2eJfuW+bOqlZZT/EygeZLl0ML4V4Fb5P9MmaWfEiSq T/axUqA7CowAa9Z0SnR2Kghd5CnFUy0mpwlI4= Date: Sun, 8 Feb 2009 01:08:52 +0300 From: Cyrill Gorcunov To: Jiri Slaby Cc: lenb@kernel.org, linux-kernel@vger.kernel.org, Pavel Machek , "Rafael J. Wysocki" Subject: Re: [PATCH v2 1/1] x86_64: acpi/wakeup_64 cleanup Message-ID: <20090207220852.GA9298@localhost> References: <1234028641-5072-1-git-send-email-jirislaby@gmail.com> <1234043558-15784-1-git-send-email-jirislaby@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1234043558-15784-1-git-send-email-jirislaby@gmail.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Jiri Slaby - Sat, Feb 07, 2009 at 10:52:38PM +0100] | - remove %ds re-set, it's already set in wakeup_long64 | - remove double labels and alignment (ENTRY already adds both) | - use meaningful resume point labelname | - skip alignment while jumping from wakeup_long64 to the resume point | - remove .size, .type and unused labels | [v2] | - added ENDPROCs | | Signed-off-by: Jiri Slaby | Cc: Len Brown | Cc: Pavel Machek | Cc: Rafael J. Wysocki | --- | arch/x86/kernel/acpi/wakeup_64.S | 26 +++++++------------------- | 1 files changed, 7 insertions(+), 19 deletions(-) | | diff --git a/arch/x86/kernel/acpi/wakeup_64.S b/arch/x86/kernel/acpi/wakeup_64.S | index bcc2934..b5dee6a 100644 | --- a/arch/x86/kernel/acpi/wakeup_64.S | +++ b/arch/x86/kernel/acpi/wakeup_64.S | @@ -13,7 +13,6 @@ | * Hooray, we are in Long 64-bit mode (but still running in low memory) | */ | ENTRY(wakeup_long64) | -wakeup_long64: | movq saved_magic, %rax | movq $0x123456789abcdef0, %rdx | cmpq %rdx, %rax | @@ -34,16 +33,12 @@ wakeup_long64: | | movq saved_rip, %rax | jmp *%rax | +ENDPROC(wakeup_long64) | | bogus_64_magic: | jmp bogus_64_magic | | - .align 2 | - .p2align 4,,15 | -.globl do_suspend_lowlevel | - .type do_suspend_lowlevel,@function | -do_suspend_lowlevel: | -.LFB5: | +ENTRY(do_suspend_lowlevel) | subq $8, %rsp | xorl %eax, %eax | call save_processor_state | @@ -67,7 +62,7 @@ do_suspend_lowlevel: | pushfq | popq pt_regs_flags(%rax) | | - movq $.L97, saved_rip(%rip) | + movq $resume_point, saved_rip(%rip) | | movq %rsp, saved_rsp | movq %rbp, saved_rbp | @@ -79,13 +74,9 @@ do_suspend_lowlevel: | movl $3, %edi | xorl %eax, %eax | jmp acpi_enter_sleep_state | -.L97: | - .p2align 4,,7 | -.L99: | - .align 4 | - movl $24, %eax | - movw %ax, %ds | | + .align 4 | +resume_point: | /* We don't restore %rax, it must be 0 anyway */ | movq $saved_context, %rax | movq saved_context_cr4(%rax), %rbx | @@ -117,12 +108,9 @@ do_suspend_lowlevel: | xorl %eax, %eax | addq $8, %rsp | jmp restore_processor_state | -.LFE5: | -.Lfe5: | - .size do_suspend_lowlevel, .Lfe5-do_suspend_lowlevel | - | +ENDPROC(do_suspend_lowlevel) | + | .data | -ALIGN | ENTRY(saved_rbp) .quad 0 | ENTRY(saved_rsi) .quad 0 | ENTRY(saved_rdi) .quad 0 | -- | 1.6.1.2 | Acked-by: Cyrill Gorcunov Thanks Jiri! - Cyrill -