From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755496AbZBGWzQ (ORCPT ); Sat, 7 Feb 2009 17:55:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753655AbZBGWzF (ORCPT ); Sat, 7 Feb 2009 17:55:05 -0500 Received: from mail-bw0-f161.google.com ([209.85.218.161]:36693 "EHLO mail-bw0-f161.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753567AbZBGWzD (ORCPT ); Sat, 7 Feb 2009 17:55:03 -0500 X-Greylist: delayed 37884 seconds by postgrey-1.27 at vger.kernel.org; Sat, 07 Feb 2009 17:55:02 EST DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:in-reply-to:user-agent; b=pTl4Ok8tc64KagOHxcFZDx5QAzzDISTRKBRI3QWEJ2plzgmAnKYyHP9Yuw2I/+//j+ ftFaGemcR5bKiz/wTjfb7XLEtbflRieHEdpAKQtS6V3tJT961B7Xp4+bvjU1tEW+K2nc X3MuMkcjcnx4DbNMG3v+fYwTIEK7r7IKgYMck= Date: Sat, 7 Feb 2009 23:55:56 +0100 From: Jarek Poplawski To: Ira Snyder Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, David Miller , Dai Haruki , Andy Fleming Subject: Re: [BUG BISECTED] boot hangs while bringing up gianfar ethernet Message-ID: <20090207225555.GA2680@ami.dom.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090129194145.GA4647@ovro.caltech.edu> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ira Snyder wrote, On 01/29/2009 08:41 PM: > Hello, > > I'm working on a Freescale MPC8349EMDS board. I have been booting it > over NFS for a long time now. I try to run the latest git kernels to > find possible problems. > > Recently, I haven't been able to boot over NFS anymore. When the machine > tries to bring up the ethernet interface, it just hangs forever. There > are no softlockup warnings, the machine has locked up completely. > > Here is the commit I bisected it down to. I tried running git revert, > but there have been other changes which prevent an easy revert. > > After building each kernel, I compiled and used the dts file from that > kernel. There shouldn't be any conflicts there. > > I'm happy to test patches to fix the problem. > > Thanks, > Ira > > 8c7396aebb68994c0519e438eecdf4d5fa9c7844 is first bad commit > commit 8c7396aebb68994c0519e438eecdf4d5fa9c7844 > Author: Dai Haruki > Date: Wed Dec 17 16:52:00 2008 -0800 > > gianfar: Merge Tx and Rx interrupt for scheduling clean up ring Hi, Could you try this patch? Thanks, Jarek P. --- drivers/net/gianfar.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index acae2d8..1335d89 100644 --- a/drivers/net/gianfar.c +++ b/drivers/net/gianfar.c @@ -1629,6 +1629,8 @@ static void gfar_schedule_cleanup(struct net_device *dev) if (netif_rx_schedule_prep(&priv->napi)) { gfar_write(&priv->regs->imask, IMASK_RTX_DISABLED); __netif_rx_schedule(&priv->napi); + } else { + gfar_write(&priv->regs->ievent, IEVENT_RTX_MASK); } spin_unlock(&priv->rxlock);