From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754417AbZBIBWQ (ORCPT ); Sun, 8 Feb 2009 20:22:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753719AbZBIBWA (ORCPT ); Sun, 8 Feb 2009 20:22:00 -0500 Received: from palinux.external.hp.com ([192.25.206.14]:54743 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753635AbZBIBV7 (ORCPT ); Sun, 8 Feb 2009 20:21:59 -0500 Date: Sun, 8 Feb 2009 18:21:40 -0700 From: Matthew Wilcox To: Julia Lawall Cc: jbarnes@virtuousgeek.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 4/6] drivers/pci: introduce missing kfree Message-ID: <20090209012140.GJ31509@parisc-linux.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 08, 2009 at 10:45:24PM +0100, Julia Lawall wrote: > From: Julia Lawall > > Error handling code following a kmalloc should free the allocated data. > Since the subsequent code that could provoke an error does not use the > allocated data, the allocation is just moved below it. > > Signed-off-by: Julia Lawall Reviewed-by: Matthew Wilcox -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."