From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yinghai@kernel.org>,
"Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: check_timer cleanup
Date: Mon, 9 Feb 2009 09:15:42 +0100 [thread overview]
Message-ID: <20090209081542.GF24420@elte.hu> (raw)
In-Reply-To: <498E6A3C.6020004@kernel.org>
* Yinghai Lu <yinghai@kernel.org> wrote:
> Impact: remove extra unmask, and pair disable/enable
>
> for edge trigger io-apic routing, already unmasked via setup_IO_APIC_irq,
> so don't unmask it again.
>
> also do call local_irq_disable() between timer_irq_works(), between it does call
> local_irq_enable() inside.
> also remove not needed apic version reading for 64bit
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>
> ---
> arch/x86/kernel/io_apic.c | 30 ++++++++++++++++++++++--------
> 1 file changed, 22 insertions(+), 8 deletions(-)
applied to tip/x86/apic, thanks Yinghai. Maybe this even solves some of the spurious
detection troubles we had in this code.
Ingo
next prev parent reply other threads:[~2009-02-09 8:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090206220716.GA15319@elte.hu>
[not found] ` <498D55A4.7000608@kernel.org>
[not found] ` <20090207165901.GA32116@elte.hu>
2009-02-08 5:14 ` [PATCH] x86: check_timer cleanup Yinghai Lu
2009-02-09 8:15 ` Ingo Molnar [this message]
2009-02-09 11:38 ` Maciej W. Rozycki
2009-02-09 11:45 ` Ingo Molnar
2009-02-09 12:34 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209081542.GF24420@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox