From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [PATCH] PCI/MSI: fix msi_mask() (rev. 2)
Date: Mon, 9 Feb 2009 09:23:50 -0800 [thread overview]
Message-ID: <200902090923.51160.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <20090209032747.GK31509@parisc-linux.org>
On Sunday, February 8, 2009 7:27 pm Matthew Wilcox wrote:
> On Mon, Feb 09, 2009 at 10:40:55AM +0900, Hidetoshi Seto wrote:
> > The commit bffac3c593eba1f9da3efd0199e49ea6558a40ce ("PCI MSI: Fix
> > undefined shift by 32") does:
>
> I think the commit message could be worded somewhat better, and I think
> I should be credited as the author of the patch. How about this?
>
> ----
>
> From: Matthew Wilcox <willy@linux.intel.com>
>
> Hidetoshi Seto points out that commit
> bffac3c593eba1f9da3efd0199e49ea6558a40ce has wrong values in the
> array. Rather than correct the array, we can just use a bounds check
> and perform the calculation specified in the comment. As a bonus, this
> will not run off the end of the array if the device specifies an illegal
> value in the MSI capcbility.
>
> Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Applied to my for-linus branch, thanks guys.
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2009-02-09 17:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 2:47 [PATCH] PCI/MSI: fix msi_mask() Hidetoshi Seto
2009-02-08 11:26 ` Matthew Wilcox
2009-02-09 1:38 ` Hidetoshi Seto
2009-02-09 1:40 ` [PATCH] PCI/MSI: fix msi_mask() (rev. 2) Hidetoshi Seto
2009-02-09 3:27 ` Matthew Wilcox
2009-02-09 4:31 ` Hidetoshi Seto
2009-02-09 17:23 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902090923.51160.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox