From: Ingo Molnar <mingo@elte.hu>
To: Mandeep Singh Baines <msb@google.com>
Cc: fweisbec@gmail.com, linux-kernel@vger.kernel.org,
rientjes@google.com, mbligh@google.com, thockin@google.com,
akpm@linux-foundation.org
Subject: Re: [PATCH] softlockup: remove timestamp checking from hung_task
Date: Mon, 9 Feb 2009 11:04:52 +0100 [thread overview]
Message-ID: <20090209100452.GD20467@elte.hu> (raw)
In-Reply-To: <20090206233747.GA8747@google.com>
* Mandeep Singh Baines <msb@google.com> wrote:
> Patch against tip/core/softlockup
>
> ---
> Impact: saves sizeof(long) bytes per task_struct
>
> By guaranteeing that sysctl_hung_task_timeout_secs have elapsed between
> tasklist scans we can avoid using timestamps.
>
> Signed-off-by: Mandeep Singh Baines <msb@google.com>
> ---
> include/linux/sched.h | 1 -
> kernel/fork.c | 8 +++-----
> kernel/hung_task.c | 48 +++++++++---------------------------------------
> 3 files changed, 12 insertions(+), 45 deletions(-)
Nice simplification!
Applied to tip/core/softlockup, thanks Mandeep.
(i fixed the one scripts/checkpatch.pl error that your patch triggered)
Ingo
prev parent reply other threads:[~2009-02-09 10:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 23:37 [PATCH] softlockup: remove timestamp checking from hung_task Mandeep Singh Baines
2009-02-07 16:23 ` Frederic Weisbecker
2009-02-07 16:34 ` Frederic Weisbecker
2009-02-07 16:51 ` Frederic Weisbecker
2009-02-07 17:02 ` Frederic Weisbecker
2009-02-09 19:29 ` Mandeep Singh Baines
2009-02-09 19:54 ` Frederic Weisbecker
2009-02-09 10:04 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209100452.GD20467@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@google.com \
--cc=msb@google.com \
--cc=rientjes@google.com \
--cc=thockin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox