From: Ingo Molnar <mingo@elte.hu>
To: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Cc: H Peter Anvin <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: Add clflush before monitor for Intel 7400 series - v2
Date: Mon, 9 Feb 2009 11:15:52 +0100 [thread overview]
Message-ID: <20090209101552.GF20467@elte.hu> (raw)
In-Reply-To: <20090207005205.GB17586@linux-os.sc.intel.com>
* Pallipadi, Venkatesh <venkatesh.pallipadi@intel.com> wrote:
> For Intel 7400 series CPUs, the recommendation is to use a clflush on the
> monitored address just before monitor and mwait pair [1]. This clflush makes sure
> that there are no false wakeups from mwait when the monitored address was recently
> written to.
>
> [1] "MONITOR/MWAIT Recommendations for Intel Xeon Processor 7400 series"
> section in specification update document of 7400 series
> http://download.intel.com/design/xeon/specupdt/32033601.pdf
>
> Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
>
> ---
>
> Earlier patch:
> http://marc.info/?l=linux-kernel&m=122341330606025&w=2
>
> Current changes:
> Minor modification based on Peter's comment
>
> arch/x86/include/asm/cpufeature.h | 1 +
> arch/x86/kernel/cpu/intel.c | 3 +++
> arch/x86/kernel/process.c | 6 ++++++
> 3 files changed, 10 insertions(+)
applied to tip/x86/urgent, thanks Venki!
Ingo
next prev parent reply other threads:[~2009-02-09 10:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-07 0:52 [PATCH] x86: Add clflush before monitor for Intel 7400 series - v2 Pallipadi, Venkatesh
2009-02-09 10:15 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-02-07 0:47 Pallipadi, Venkatesh
2009-02-07 14:02 ` Alan Cox
2009-02-07 16:47 ` Pallipadi, Venkatesh
2009-02-09 5:53 ` Nick Piggin
2009-02-09 21:37 ` Pallipadi, Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209101552.GF20467@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox