public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 4/5] tracing/core: drop the cpu field from trace_entry
Date: Mon, 9 Feb 2009 15:03:21 +0100	[thread overview]
Message-ID: <20090209140321.GA20758@elte.hu> (raw)
In-Reply-To: <20090209134744.GC4705@nowhere>


* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> On Mon, Feb 09, 2009 at 10:53:24AM +0100, Ingo Molnar wrote:
> > 
> > * Frederic Weisbecker <fweisbec@gmail.com> wrote:
> > 
> > > Impact: fix a bug on cpu output
> > > 
> > > While looking on the function tracer traces, I first cheered up:
> > > 
> > >             TASK-PID    CPU#    TIMESTAMP  FUNCTION
> > >                | |       |          |         |
> > >          firefox-4622  [081]  1315.790405: lapic_next_event <-clockevents_program_event
> > >          firefox-4622  [178]  1315.790405: native_apic_mem_write <-lapic_next_event
> > >          firefox-4622  [020]  1315.790406: perf_counter_unthrottle <-smp_apic_timer_interrupt
> > > 
> > > But no, actually I don't have so many cpus...
> > 
> > incidentally, Steve came up with the exact same patch :)
> > 
> > 	Ingo
> 
> Heh, I guess the moon inspired both of us in the name of tracing, or
> something like that...

It was exactly at around the time Thomas complained over IRC
about the visible CPU# breakage in the tracer output.

So i blame it on telepathy ;-)

	Ingo

  reply	other threads:[~2009-02-09 14:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-07 22:32 [PATCH 4/5] tracing/core: drop the cpu field from trace_entry Frederic Weisbecker
2009-02-09  9:53 ` Ingo Molnar
2009-02-09 13:47   ` Frederic Weisbecker
2009-02-09 14:03     ` Ingo Molnar [this message]
2009-02-09 16:07       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090209140321.GA20758@elte.hu \
    --to=mingo@elte.hu \
    --cc=acme@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox