From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] ring_buffer: fix typing mistake
Date: Mon, 9 Feb 2009 15:20:30 +0100 [thread overview]
Message-ID: <20090209142030.GA28580@elte.hu> (raw)
In-Reply-To: <alpine.DEB.1.10.0902090916340.14528@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Mon, 9 Feb 2009, Lai Jiangshan wrote:
>
> >
> > Impact: Fix bug
> >
> > I found several very very curious line.
> > It's so curious that it may be brought by typing mistake.
> >
> > When (cpu_buffer->reader_page == cpu_buffer->commit_page):
> >
> > 1) We haven't copied it for bpage is changed:
> > bpage = cpu_buffer->reader_page->page;
> > memcpy(bpage->data, cpu_buffer->reader_page->page->data + read ... )
> > 2) We need update cpu_buffer->reader_page->read, but
> > "cpu_buffer->reader_page += read;" is not right.
>
> Ouch! That is a bug.
>
> Ingo, this is an urgent fix. Want me to pull it in and send it off to you?
Please do, yes.
Ingo
next prev parent reply other threads:[~2009-02-09 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 6:21 [PATCH 1/2] ring_buffer: fix typing mistake Lai Jiangshan
2009-02-09 14:18 ` Steven Rostedt
2009-02-09 14:20 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-02-09 15:17 [PATCH 0/2] git pull request for tip/tracing/urgent Steven Rostedt
2009-02-09 15:17 ` [PATCH 1/2] ring_buffer: fix typing mistake Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209142030.GA28580@elte.hu \
--to=mingo@elte.hu \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox