From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754582AbZBIF77 (ORCPT ); Mon, 9 Feb 2009 00:59:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751534AbZBIF7v (ORCPT ); Mon, 9 Feb 2009 00:59:51 -0500 Received: from smtp114.mail.mud.yahoo.com ([209.191.84.67]:30096 "HELO smtp114.mail.mud.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751505AbZBIF7u (ORCPT ); Mon, 9 Feb 2009 00:59:50 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com.au; h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id; b=1ydnGhXYsq9Csd9zBiFKDx459w8KOHbTQr5qhfKkIA2Ih45khYKSggXQddu6nnCTSFSfdoE4DNb65AlvfzH6XgXYFFpqOrpd1u/3T1Jx+PvxakwNWxZy2iVDl6yqJhWJfqy9C+FBDgZH+KtxyVsYpS47hydtHepm1s5SMTrLooY= ; X-YMail-OSG: bEqgd5EVM1k1geIMpvzvmuQ7FJBCymYtSq08HOS2SqI1rTR4JQaAY69mWK6ATJ.G37uSmtWynTOLwWo_zyK2jOtTDYqGAN4tBsN_t5yRawuVOGfqnqfV9x86li1IflvdQh083D.Cy3hQLCR7fEnw34ZXvw-- X-Yahoo-Newman-Property: ymail-3 From: Nick Piggin To: wixor Subject: Re: viafb triggers BUG at mm/vmalloc.c:294 [kernel 2.6.28.3] Date: Mon, 9 Feb 2009 16:59:20 +1100 User-Agent: KMail/1.9.51 (KDE/4.0.4; ; ) Cc: Alexey Dobriyan , Arjan van de Ven , JosephChan@via.com.tw, linux-kernel@vger.kernel.org References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Message-Id: <200902091659.21446.nickpiggin@yahoo.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by alpha id n19604wM014535 On Sunday 08 February 2009 21:25:13 wixor wrote:> No, it didn't help really. Even with vmalloc=300M after a couple> modprobe/rmmods i got the same BUG. And I didn't manage to get> anything on display. Moreover, rmmod doesn't bring back the vga> console. Thanks for reporting. I have a fix for this bug which is anoverflow issue reported by XFS guys... I've just been holdingoff merging it because they still seem to have a problemwith vmap that I'm trying to track down. But if you could test this patch, it would be appreciated. Thanks,Nick --- mm/vmalloc.c | 6 ++++++ 1 file changed, 6 insertions(+) Index: linux-2.6/mm/vmalloc.c===================================================================--- linux-2.6.orig/mm/vmalloc.c+++ linux-2.6/mm/vmalloc.c@@ -334,6 +334,9 @@ retry: addr = ALIGN(vstart, align); spin_lock(&vmap_area_lock);+ if (addr + size < addr)+ goto overflow;+ /* XXX: could have a last_hole cache */ n = vmap_area_root.rb_node; if (n) {@@ -365,6 +368,8 @@ retry: while (addr + size > first->va_start && addr + size <= vend) { addr = ALIGN(first->va_end + PAGE_SIZE, align);+ if (addr + size < addr)+ goto overflow; n = rb_next(&first->rb_node); if (n)@@ -375,6 +380,7 @@ retry: } found: if (addr + size > vend) {+overflow: spin_unlock(&vmap_area_lock); if (!purged) { purge_vmap_area_lazy();{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I