public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Davide Rizzo <elpa.rizzo@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
	linux-arm-kernel@lists.arm.linux.org.uk, ben-linux@fluff.org,
	"Hans J. Koch" <hjk@linutronix.de>, Greg KH <gregkh@suse.de>
Subject: Re: [PATCH 1/2] User access to internal clocks
Date: Mon, 9 Feb 2009 17:10:42 +0000	[thread overview]
Message-ID: <20090209171042.GA19453@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <8447d6730902090904y138af9c6r3d64278bc7a30811@mail.gmail.com>

On Mon, Feb 09, 2009 at 06:04:29PM +0100, Davide Rizzo wrote:
> To: Greg KH <gregkh@suse.de>
> Cc: "Hans J. Koch" <hjk@linutronix.de>, linux-kernel@vger.kernel.org,
> ben-linux@fluff.org, linux-api@vger.kernel.org
> 
> This driver is for user level programs to interact with system clocks.
> It allows to read and modify rates and parents, using virtual files.
> It requires the implementation of 2 additional functions in the clk interface:
>  clk_for_each() and clk_name().
> Actually I implemented that functions only for Samsung S3C24xx platform.

NAK.

> +       name = clk_get_name(clk);

This implies that there is a 1:1 relationship between a 'name' and a
struct clk.  No such thing exists (and where it does, it's being
eliminated in ARM because it's just plain and simple WRONG.)

  reply	other threads:[~2009-02-09 17:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-09 17:04 [PATCH 1/2] User access to internal clocks Davide Rizzo
2009-02-09 17:10 ` Russell King - ARM Linux [this message]
2009-02-09 17:44   ` Davide Rizzo
2009-02-09 17:55     ` Russell King - ARM Linux
2009-02-09 18:17       ` Davide Rizzo
2009-02-09 18:54         ` Davide Rizzo
2009-02-09 19:01           ` Russell King - ARM Linux
2009-02-09 21:06             ` Davide Rizzo
2009-02-09 17:12 ` Hans J. Koch
2009-02-09 18:12 ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090209171042.GA19453@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=ben-linux@fluff.org \
    --cc=elpa.rizzo@gmail.com \
    --cc=gregkh@suse.de \
    --cc=hjk@linutronix.de \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox