From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756041AbZBIRW3 (ORCPT ); Mon, 9 Feb 2009 12:22:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754677AbZBIRWS (ORCPT ); Mon, 9 Feb 2009 12:22:18 -0500 Received: from ns2.suse.de ([195.135.220.15]:48901 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754339AbZBIRWR (ORCPT ); Mon, 9 Feb 2009 12:22:17 -0500 Date: Mon, 9 Feb 2009 09:12:54 -0800 From: Greg KH To: "Brown, Len" Cc: Arjan van de Ven , Stefan Lippers-Hollmann , "linux-kernel@vger.kernel.org" , "stable@kernel.org" Subject: Re: patch acpi-remove-locking-from-pm1x_sts-register-reads.patch added to 2.6.28-stable tree Message-ID: <20090209171254.GA24704@suse.de> References: <20090208211932.4CAB349019@coco.kroah.org> <200902090124.44228.s.L-H@gmx.de> <20090209162402.GA13931@suse.de> <20090209083050.361e997d@infradead.org> <20090209164905.GA5420@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 09, 2009 at 10:00:10AM -0700, Brown, Len wrote: > > >> why is this -stable material? > >> this is a performance improvement.... > > > >It is, and not a bugfix? If so, I'll drop it. > > yes, removing the un-necessary locking > it is a scaling performance improvement. > > The code has been this way for years. > The reason we noticed this issue recently > is because of the emergence of systems that > simultaneously have many threads and also > have deep C-states. > > In 2.6.30 we plan larger improvements in this area. Ok, I'll go drop this patch from the -stable trees. thanks, greg k-h