From: Ira Snyder <iws@ovro.caltech.edu>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
David Miller <davem@davemloft.net>,
Dai Haruki <dai.haruki@freescale.com>,
Andy Fleming <afleming@freescale.com>
Subject: Re: [BUG BISECTED] boot hangs while bringing up gianfar ethernet
Date: Mon, 9 Feb 2009 09:22:17 -0800 [thread overview]
Message-ID: <20090209172216.GA11312@ovro.caltech.edu> (raw)
In-Reply-To: <20090207225555.GA2680@ami.dom.local>
On Sat, Feb 07, 2009 at 11:55:56PM +0100, Jarek Poplawski wrote:
>
> Hi,
>
> Could you try this patch?
>
> Thanks,
> Jarek P.
> ---
>
> drivers/net/gianfar.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c
> index acae2d8..1335d89 100644
> --- a/drivers/net/gianfar.c
> +++ b/drivers/net/gianfar.c
> @@ -1629,6 +1629,8 @@ static void gfar_schedule_cleanup(struct net_device *dev)
> if (netif_rx_schedule_prep(&priv->napi)) {
> gfar_write(&priv->regs->imask, IMASK_RTX_DISABLED);
> __netif_rx_schedule(&priv->napi);
> + } else {
> + gfar_write(&priv->regs->ievent, IEVENT_RTX_MASK);
> }
>
> spin_unlock(&priv->rxlock);
>
It works fine for me, the board now boots up normally.
Thanks for the patch,
Ira
next prev parent reply other threads:[~2009-02-09 17:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 19:41 [BUG BISECTED] boot hangs while bringing up gianfar ethernet Ira Snyder
2009-01-30 14:57 ` Peter Korsgaard
2009-02-07 22:55 ` Jarek Poplawski
2009-02-09 13:36 ` Peter Korsgaard
2009-02-09 13:54 ` Jarek Poplawski
2009-02-09 17:22 ` Ira Snyder [this message]
2009-02-09 19:34 ` [PATCH net] gianfar: Fix " Jarek Poplawski
2009-02-09 22:58 ` David Miller
2009-02-10 11:39 ` Jarek Poplawski
2009-02-09 19:40 ` [PATCH v2 " Jarek Poplawski
2009-02-09 22:59 ` David Miller
2009-02-09 18:53 ` [BUG BISECTED] " Andy Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209172216.GA11312@ovro.caltech.edu \
--to=iws@ovro.caltech.edu \
--cc=afleming@freescale.com \
--cc=dai.haruki@freescale.com \
--cc=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox