From: Alex Chiang <achiang@hp.com>
To: tony.luck@intel.com,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
stable@kernel.org, linux-ia64@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 2/2] ia64: Remove redundant cpu_clear() in __cpu_disable path
Date: Mon, 9 Feb 2009 11:16:57 -0700 [thread overview]
Message-ID: <20090209181657.GF19064@ldl.fc.hp.com> (raw)
In-Reply-To: <20090209181338.GD19064@ldl.fc.hp.com>
The second call to cpu_clear() is redundant, as we've already removed
the CPU from cpu_online_map before calling migrate_platform_irqs().
Cc: stable@kernel.org
Signed-off-by: Alex Chiang <achiang@hp.com>
---
arch/ia64/kernel/smpboot.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/ia64/kernel/smpboot.c b/arch/ia64/kernel/smpboot.c
index 2ec5bbf..5229054 100644
--- a/arch/ia64/kernel/smpboot.c
+++ b/arch/ia64/kernel/smpboot.c
@@ -740,11 +740,10 @@ int __cpu_disable(void)
if (migrate_platform_irqs(cpu)) {
cpu_set(cpu, cpu_online_map);
- return (-EBUSY);
+ return -EBUSY;
}
remove_siblinginfo(cpu);
- cpu_clear(cpu, cpu_online_map);
fixup_irqs();
local_flush_tlb_all();
cpu_clear(cpu, cpu_callin_map);
--
1.6.0.1.161.g7f314
next prev parent reply other threads:[~2009-02-09 18:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 18:13 [PATCH v2 0/2] ia64: prevent irq migration race in __cpu_disable path Alex Chiang
2009-02-09 18:16 ` [PATCH v2 1/2] Revert "[IA64] prevent ia64 from invoking irq handlers on offline CPUs" Alex Chiang
2009-02-09 21:17 ` Alex Chiang
2009-02-09 23:33 ` Alex Chiang
2009-02-09 23:52 ` Russ Anderson
2009-02-09 18:16 ` Alex Chiang [this message]
2009-02-10 12:36 ` [PATCH v2 0/2] ia64: prevent irq migration race in __cpu_disable path Paul E. McKenney
2009-02-10 16:11 ` Alex Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209181657.GF19064@ldl.fc.hp.com \
--to=achiang@hp.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=stable@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox