Re: [PATCH 1/4] module_param: bool params should still work with #include <stdbool.h>

Re: [PATCH 1/4] module_param: bool params should still work with #include <stdbool.h>

[Rusty Russell]

On Monday 09 February 2009 18:22:26 Rusty Russell wrote:
> 
> Code such as "module_param(foo, bool, 0400)" no longer compiles if one
> includes stdbool.h: the ISO standard requires that this "#define bool
> _Bool".

Of course, better fix is not to use stdbool.h, but leave it to the
typedef in kernel/types.h.

Forget this patch...
Rusty.

[PATCH 1/4] module_param: bool params should still work with #include <stdbool.h>

[Rusty Russell]

Code such as "module_param(foo, bool, 0400)" no longer compiles if one
includes stdbool.h: the ISO standard requires that this "#define bool
_Bool".

The fix is simple: define those as well.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h
--- a/include/linux/moduleparam.h
+++ b/include/linux/moduleparam.h
@@ -180,6 +180,11 @@ extern int param_get_bool(char *buffer, 
 extern int param_get_bool(char *buffer, struct kernel_param *kp);
 #define param_check_bool(name, p) __param_check(name, p, int)
 
+/* #include <stdbool.h> transforms module_param(foo, bool, 0). */
+#define param_set__Bool param_set_bool
+#define param_get__Bool param_get_bool
+#define param_check__Bool param_check_bool
+
 extern int param_set_invbool(const char *val, struct kernel_param *kp);
 extern int param_get_invbool(char *buffer, struct kernel_param *kp);
 #define param_check_invbool(name, p) __param_check(name, p, int)