From: Rusty Russell <rusty@rustcorp.com.au>
To: Ingo Molnar <mingo@elte.hu>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, Mike Travis <travis@sgi.com>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH 2/3] cpumask: fix powernow-k8: partial revert of 2fdf66b491ac706657946442789ec644cc317e1a
Date: Mon, 9 Feb 2009 21:01:53 +1030 [thread overview]
Message-ID: <200902092101.54193.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090209101723.GH20467@elte.hu>
On Monday 09 February 2009 20:47:23 Ingo Molnar wrote:
> > - goto err_out;
> > + kfree(data);
> > + return -ENODEV;
> > }
>
> hm, why the 3-way duplication of this pattern:
>
> > + kfree(data);
> > + return -ENODEV;
>
> because it's a straight revert?
Yep, it reverts the changes to that one file.
Cheers,
Rusty.
prev parent reply other threads:[~2009-02-09 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-07 7:39 [PATCH 2/3] cpumask: fix powernow-k8: partial revert of 2fdf66b491ac706657946442789ec644cc317e1a Rusty Russell
2009-02-07 7:45 ` Yinghai Lu
2009-02-07 7:50 ` Rusty Russell
2009-02-07 7:59 ` Yinghai Lu
2009-02-09 10:17 ` Ingo Molnar
2009-02-09 10:31 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902092101.54193.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=travis@sgi.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox