From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756824AbZBJVmX (ORCPT ); Tue, 10 Feb 2009 16:42:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755441AbZBJVmP (ORCPT ); Tue, 10 Feb 2009 16:42:15 -0500 Received: from mail-fx0-f25.google.com ([209.85.220.25]:42053 "EHLO mail-fx0-f25.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754727AbZBJVmO (ORCPT ); Tue, 10 Feb 2009 16:42:14 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=opwVgFIIgCA70gXqRHMFnQam4l6l4VYU7tsUiYyAOTb2Ww4kJ/nwgSMPVUE+rnJJqR KsM1pb16x+pmDsg+r616fdk38NSSqZtqosLjTyHpTtvFgtadCGEDDJyBFeQfJ9RgSdXT dNdUATMXc7TBgG7o6prSQXb9Chm+QsrVEgvS4= Date: Tue, 10 Feb 2009 22:42:08 +0100 From: Frederic Weisbecker To: Hannes Eder Cc: Ingo Molnar , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] trace: fix sparse warnings: make symbols static Message-ID: <20090210214207.GB4879@nowhere> References: <20090210184214.28131.90564.stgit@vmbox.hanneseder.net> <20090210184357.28131.39458.stgit@vmbox.hanneseder.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090210184357.28131.39458.stgit@vmbox.hanneseder.net> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 10, 2009 at 07:44:12PM +0100, Hannes Eder wrote: > Impact: make global variables and a global function static > > The function '__trace_userstack' does not seem to have a caller, so it > is commented out. I guess it can even be dropped :-) > Fix this sparse warnings: > kernel/trace/trace.c:82:5: warning: symbol 'tracing_disabled' was not declared. Should it be static? > kernel/trace/trace.c:600:10: warning: symbol 'trace_record_cmdline_disabled' was not declared. Should it be static? > kernel/trace/trace.c:957:6: warning: symbol '__trace_userstack' was not declared. Should it be static? > kernel/trace/trace.c:1694:5: warning: symbol 'tracing_release' was not declared. Should it be static? > > Signed-off-by: Hannes Eder > --- > kernel/trace/trace.c | 10 ++++++---- > 1 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index ef4dbac..0e7c84f 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -79,7 +79,7 @@ static int dummy_set_flag(u32 old_flags, u32 bit, int set) > * of the tracer is successful. But that is the only place that sets > * this back to zero. > */ > -int tracing_disabled = 1; > +static int tracing_disabled = 1; > > static DEFINE_PER_CPU(local_t, ftrace_cpu_disabled); > > @@ -597,7 +597,7 @@ static int cmdline_idx; > static DEFINE_SPINLOCK(trace_cmdline_lock); > > /* temporary disable recording */ > -atomic_t trace_record_cmdline_disabled __read_mostly; > +static atomic_t trace_record_cmdline_disabled __read_mostly; > > static void trace_init_cmdlines(void) > { > @@ -954,10 +954,12 @@ static void ftrace_trace_userstack(struct trace_array *tr, > #endif > } > > -void __trace_userstack(struct trace_array *tr, unsigned long flags) > +#ifdef UNUSED > +static void __trace_userstack(struct trace_array *tr, unsigned long flags) > { > ftrace_trace_userstack(tr, flags, preempt_count()); > } > +#endif /* UNUSED */ > > static void > ftrace_trace_special(void *__tr, > @@ -1691,7 +1693,7 @@ int tracing_open_generic(struct inode *inode, struct file *filp) > return 0; > } > > -int tracing_release(struct inode *inode, struct file *file) > +static int tracing_release(struct inode *inode, struct file *file) > { > struct seq_file *m = (struct seq_file *)file->private_data; > struct trace_iterator *iter = m->private; > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html