From: David Brownell <david-b@pacbell.net>
To: Kalle Jokiniemi <kalle.jokiniemi@digia.com>
Cc: lrg@slimlogic.co.uk, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
jouni.hogander@nokia.com, broonie@sirena.org.uk
Subject: Re: [PATCH 0/2] TWL: USB: Start using twl4030/5030 regulator driver
Date: Tue, 10 Feb 2009 23:23:30 -0800 [thread overview]
Message-ID: <200902102323.30395.david-b@pacbell.net> (raw)
In-Reply-To: <1234336002-26372-1-git-send-email-kalle.jokiniemi@digia.com>
On Tuesday 10 February 2009, Kalle Jokiniemi wrote:
> These couple of patches enable dynamic swithcing of the
> regulators used by twl4030 usb tranceiver.
>
> This set replaces the single patch "USB: disable twl4030
> USB regulators when cable unplugged" sent previously.
> The change to previous version is that possible errors
> in regulator_get are now handled and the twl4030 usb
> driver requires TWL_REGULATOR support to be compiled.
It'd make more sense to me as a single patch ... :)
And also, instead of *continuing* after the regulators
can't be acquired, it's better to abort. It's not
going to be able to do anything ... so don't finish
probing, and don't register this "dead" transceiver.
- Dave
next prev parent reply other threads:[~2009-02-11 7:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 7:06 [PATCH 0/2] TWL: USB: Start using twl4030/5030 regulator driver Kalle Jokiniemi
2009-02-11 7:06 ` [PATCH 1/2] TWL: USB: disable VUSB regulators when cable unplugged Kalle Jokiniemi
2009-02-11 7:06 ` [PATCH 2/2] USB: OTG: Twl4030 depends on REGULATOR_TWL4030 Kalle Jokiniemi
2009-02-11 7:23 ` David Brownell [this message]
2009-02-11 10:47 ` [PATCH 0/2] TWL: USB: Start using twl4030/5030 regulator driver Kalle Jokiniemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902102323.30395.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=broonie@sirena.org.uk \
--cc=jouni.hogander@nokia.com \
--cc=kalle.jokiniemi@digia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox