From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757182AbZBLA3r (ORCPT ); Wed, 11 Feb 2009 19:29:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755899AbZBLA3f (ORCPT ); Wed, 11 Feb 2009 19:29:35 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:51899 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1755738AbZBLA3e (ORCPT ); Wed, 11 Feb 2009 19:29:34 -0500 Date: Wed, 11 Feb 2009 16:29:28 -0800 (PST) Message-Id: <20090211.162928.193706021.davem@davemloft.net> To: wli@movementarian.org Cc: kadlec@blackhole.kfki.hu, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, rusty@rustcorp.com.au Subject: Re: [PATCH] Update jhash.h with the new version of Jenkins' hash From: David Miller In-Reply-To: <20090212001223.GA5757@movementarian.org> References: <20090212001223.GA5757@movementarian.org> X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: wli@movementarian.org Date: Wed, 11 Feb 2009 19:12:23 -0500 > (double)0xdeadbeef/((unsigned long long)1 << 32) is a rather poor > approximation of (sqrt(5)-1)/2. If this value which is not the > golden ratio is arbitrary, calling it something different from > JHASH_GOLDEN_RATIO would surprise the code's readers much less. Then we can change the name, whatever... But really, anyone truly interested will read the friggin' web site where all the design documents and hash test results live.