Re: [PATCH tip 1/1] ring_buffer: pahole struct ring_buffer

[Ingo Molnar <mingo@elte.hu>]

* Arnaldo Carvalho de Melo <acme@redhat.com> wrote:

> Hi,
> 
> While fixing some bugs in pahole (built-in.o files were not being
> processed due to relocation problems) I found out about these packable
> structures:
> 
> $ pahole --packable kernel/trace/ring_buffer.o  | grep ring
> ring_buffer	72	64	8
> ring_buffer_per_cpu	112	104	8

>  ring_buffer.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> index 53ba3a6..27ef3bf 100644
> --- a/kernel/trace/ring_buffer.c
> +++ b/kernel/trace/ring_buffer.c
> @@ -273,8 +273,8 @@ struct ring_buffer {
>  	unsigned			pages;
>  	unsigned			flags;
>  	int				cpus;
> -	cpumask_var_t			cpumask;
>  	atomic_t			record_disabled;
> +	cpumask_var_t			cpumask;

Applied to tip:tracing/ring-buffer, thanks Arnaldo!

Is there anything packable in core kernel structures like task struct?

	Ingo