From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 0/8] git pull request for tip/tracing/core
Date: Wed, 11 Feb 2009 18:16:22 +0100 [thread overview]
Message-ID: <20090211171622.GA13239@elte.hu> (raw)
In-Reply-To: <alpine.DEB.1.10.0902111158380.15438@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Wed, 11 Feb 2009, Steven Rostedt wrote:
>
> >
> > On Wed, 11 Feb 2009, Ingo Molnar wrote:
> >
> > >
> > > > > Steven Rostedt (7):
> > > > > ring-buffer: add NMI protection for spinlocks
> > > > > nmi: add generic nmi tracking state
> > >
> > > hm, this commit breaks a number of non-x86 architectures the following way:
> > >
> > > In file included from /home/mingo/tip/include/linux/interrupt.h:12,
> > > from /home/mingo/tip/arch/ia64/include/asm/mca.h:16,
> > > from /home/mingo/tip/arch/ia64/kernel/asm-offsets.c:17:
> > > /home/mingo/tip/include/linux/hardirq.h:67:2: #error PREEMPT_ACTIVE too high!
> > > make[2]: *** [arch/ia64/kernel/asm-offsets.s] Error 1
>
> I just looked at alpha and arm, I'm now looking at ia64. And this could
> be an issue, since it has 14 bits for hard irqs.
>
> What would be the impact to make the preempt count a long?
Assembly code has to be audited i guess, whether it's treated as an int anywhere.
Should work i guess.
Ingo
next prev parent reply other threads:[~2009-02-11 17:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-08 5:49 [PATCH 0/8] git pull request for tip/tracing/core Steven Rostedt
2009-02-08 5:49 ` [PATCH 1/8] trace: remove deprecated entry->cpu Steven Rostedt
2009-02-08 12:29 ` Frederic Weisbecker
2009-02-08 5:49 ` [PATCH 2/8] ring-buffer: add NMI protection for spinlocks Steven Rostedt
2009-02-08 5:49 ` [PATCH 3/8] ring-buffer: allow tracing_off to be used in core kernel code Steven Rostedt
2009-02-08 5:49 ` [PATCH 4/8] ftrace, x86: rename in_nmi variable Steven Rostedt
2009-02-08 5:50 ` [PATCH 5/8] nmi: add generic nmi tracking state Steven Rostedt
2009-02-08 5:50 ` [PATCH 6/8] ftrace: change function graph tracer to use new in_nmi Steven Rostedt
2009-02-08 5:50 ` [PATCH 7/8] ring-buffer: use generic version of in_nmi Steven Rostedt
2009-02-08 5:50 ` [PATCH 8/8] trace: trivial fixes in comment typos Steven Rostedt
2009-02-09 9:37 ` [PATCH 0/8] git pull request for tip/tracing/core Ingo Molnar
2009-02-11 15:36 ` Ingo Molnar
2009-02-11 15:46 ` Steven Rostedt
2009-02-11 16:25 ` Ingo Molnar
2009-02-11 16:33 ` Steven Rostedt
2009-02-11 16:49 ` Steven Rostedt
2009-02-11 16:59 ` Steven Rostedt
2009-02-11 17:16 ` Ingo Molnar [this message]
2009-02-11 17:30 ` Steven Rostedt
2009-02-11 17:31 ` Ingo Molnar
2009-02-11 17:57 ` Luck, Tony
2009-02-11 18:23 ` Steven Rostedt
2009-02-11 18:34 ` Luck, Tony
2009-02-11 18:42 ` Steven Rostedt
2009-02-11 20:20 ` Ingo Molnar
2009-02-11 20:39 ` Jack Steiner
2009-02-12 2:39 ` Kenji Kaneshige
2009-02-12 2:43 ` Steven Rostedt
2009-02-12 3:15 ` Kenji Kaneshige
2009-02-12 3:22 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090211171622.GA13239@elte.hu \
--to=mingo@elte.hu \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox