From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
"Metzger, Markus T" <markus.t.metzger@intel.com>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] move exit_ptrace() from forget_original_parent() to do_exit()
Date: Wed, 11 Feb 2009 22:12:21 +0100 [thread overview]
Message-ID: <20090211211221.GA16857@redhat.com> (raw)
By discussion with Roland.
Call exit_ptrace() from do_exit(), no need to delay this call until
forget_original_parent().
If we ever change exit_ptrace() to do the blocking calls, it makes
sense to move it after exit_signals().
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
--- 6.29-rc3/kernel/exit.c~3_MOVE 2009-02-11 06:37:36.000000000 +0100
+++ 6.29-rc3/kernel/exit.c 2009-02-11 07:20:54.000000000 +0100
@@ -803,8 +803,6 @@ static void forget_original_parent(struc
struct task_struct *p, *n, *reaper;
LIST_HEAD(dead_childs);
- exit_ptrace(father);
-
write_lock_irq(&tasklist_lock);
reaper = find_new_reaper(father);
@@ -956,6 +954,7 @@ NORET_TYPE void do_exit(long code)
schedule();
}
+ exit_ptrace(tsk);
exit_signals(tsk); /* sets PF_EXITING */
/*
* tsk->flags are checked in the futex code to protect against
next reply other threads:[~2009-02-11 21:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 21:12 Oleg Nesterov [this message]
2009-02-20 2:28 ` [PATCH 3/4] move exit_ptrace() from forget_original_parent() to do_exit() Roland McGrath
2009-02-23 16:59 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090211211221.GA16857@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.t.metzger@intel.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox