From: Ed Cashin <ecashin@coraid.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, karaluh@karaluh.pl
Subject: Re: [PATCH 1/1] aoe: ignore vendor extension AoE responses
Date: Wed, 11 Feb 2009 19:55:49 -0500 [thread overview]
Message-ID: <20090212005549.GA8636@coraid.com> (raw)
In-Reply-To: <20090211162944.c1cdf8fb.akpm@linux-foundation.org>
On Wed, Feb 11, 2009 at 04:29:44PM -0800, Andrew Morton wrote:
> On Wed, 11 Feb 2009 19:16:44 -0500
> Ed Cashin <ecashin@coraid.com> wrote:
>
> > The Welland ME-747K-SI AoE target generates unsolicited AoE
> > responses that are marked as vendor extensions. Instead of
> > ignoring these packets, the aoe driver was generating kernel
> > messages for each unrecognized response received. This patch
> > corrects the behavior.
...
> Do you believe that this fix should be backported into earlier kernel
> versions? (2.6.28.x, 2.6.27.x, etc)
It shouldn't hurt, it can help, and it's well tested.
I am not sure how many environments have AoE packets that have vendor
extension command types, though, so I can't gauge how pressing the
need is for backporting.
If the cost of backporting is low, it probably should be backported.
--
Ed Cashin <ecashin@coraid.com>
prev parent reply other threads:[~2009-02-12 0:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 0:16 [PATCH 1/1] aoe: ignore vendor extension AoE responses Ed Cashin
2009-02-12 0:29 ` Andrew Morton
2009-02-12 0:35 ` Alex Buell
2009-02-12 1:08 ` Ed Cashin
2009-02-12 0:55 ` Ed Cashin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090212005549.GA8636@coraid.com \
--to=ecashin@coraid.com \
--cc=akpm@linux-foundation.org \
--cc=karaluh@karaluh.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox