[PATCH 1/1] aoe: ignore vendor extension AoE responses

[PATCH 1/1] aoe: ignore vendor extension AoE responses

[Ed Cashin]

The Welland ME-747K-SI AoE target generates unsolicited AoE
responses that are marked as vendor extensions.  Instead of
ignoring these packets, the aoe driver was generating kernel
messages for each unrecognized response received.  This patch
corrects the behavior.

Signed-off-by: Ed Cashin <ecashin@coraid.com>
Reported-by: karaluh@karaluh.pl
Tested-by: karaluh@karaluh.pl
---

I will place this patch in the new aoe quilt tree for
linux-next when this patch has passed LKML review.

 drivers/block/aoe/aoe.h    |    1 +
 drivers/block/aoe/aoenet.c |    2 ++
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h
index c237527..5e41e6d 100644
--- a/drivers/block/aoe/aoe.h
+++ b/drivers/block/aoe/aoe.h
@@ -18,6 +18,7 @@
 enum {
 	AOECMD_ATA,
 	AOECMD_CFG,
+	AOECMD_VEND_MIN = 0xf0,
 
 	AOEFL_RSP = (1<<3),
 	AOEFL_ERR = (1<<2),
diff --git a/drivers/block/aoe/aoenet.c b/drivers/block/aoe/aoenet.c
index 30de5b1..c6099ba 100644
--- a/drivers/block/aoe/aoenet.c
+++ b/drivers/block/aoe/aoenet.c
@@ -142,6 +142,8 @@ aoenet_rcv(struct sk_buff *skb, struct net_device *ifp, struct packet_type *pt,
 		aoecmd_cfg_rsp(skb);
 		break;
 	default:
+		if (h->cmd >= AOECMD_VEND_MIN)
+			break;	/* don't complain about vendor commands */
 		printk(KERN_INFO "aoe: unknown cmd %d\n", h->cmd);
 	}
 exit:
-- 
1.5.6.5

Re: [PATCH 1/1] aoe: ignore vendor extension AoE responses

[Andrew Morton]

On Wed, 11 Feb 2009 19:16:44 -0500
Ed Cashin <ecashin@coraid.com> wrote:

> The Welland ME-747K-SI AoE target generates unsolicited AoE
> responses that are marked as vendor extensions.  Instead of
> ignoring these packets, the aoe driver was generating kernel
> messages for each unrecognized response received.  This patch
> corrects the behavior.
> 
> Signed-off-by: Ed Cashin <ecashin@coraid.com>
> Reported-by: karaluh@karaluh.pl
> Tested-by: karaluh@karaluh.pl
> ---
> 
> I will place this patch in the new aoe quilt tree for
> linux-next when this patch has passed LKML review.
> 
>  drivers/block/aoe/aoe.h    |    1 +
>  drivers/block/aoe/aoenet.c |    2 ++
>  2 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h
> index c237527..5e41e6d 100644
> --- a/drivers/block/aoe/aoe.h
> +++ b/drivers/block/aoe/aoe.h
> @@ -18,6 +18,7 @@
>  enum {
>  	AOECMD_ATA,
>  	AOECMD_CFG,
> +	AOECMD_VEND_MIN = 0xf0,
>  
>  	AOEFL_RSP = (1<<3),
>  	AOEFL_ERR = (1<<2),
> diff --git a/drivers/block/aoe/aoenet.c b/drivers/block/aoe/aoenet.c
> index 30de5b1..c6099ba 100644
> --- a/drivers/block/aoe/aoenet.c
> +++ b/drivers/block/aoe/aoenet.c
> @@ -142,6 +142,8 @@ aoenet_rcv(struct sk_buff *skb, struct net_device *ifp, struct packet_type *pt,
>  		aoecmd_cfg_rsp(skb);
>  		break;
>  	default:
> +		if (h->cmd >= AOECMD_VEND_MIN)
> +			break;	/* don't complain about vendor commands */
>  		printk(KERN_INFO "aoe: unknown cmd %d\n", h->cmd);
>  	}
>  exit:

Do you believe that this fix should be backported into earlier kernel
versions?  (2.6.28.x, 2.6.27.x, etc)

Re: [PATCH 1/1] aoe: ignore vendor extension AoE responses

[Alex Buell]

On Wed, 11 Feb 2009 16:29:44 -0800, I waved a wand and this message
magically appears in front of Andrew Morton:

> Do you believe that this fix should be backported into earlier kernel
> versions?  (2.6.28.x, 2.6.27.x, etc)

Yes, please - I'll be using AoE on these kernels. It might also be a
good opportunity to update the AoE module, as I believe the latest out
of the kernel tree module is currently at 70, whilst the version in
2.6.27 is at 47.
-- 
http://www.munted.org.uk

Fearsome grindings.
.

Re: [PATCH 1/1] aoe: ignore vendor extension AoE responses

[Ed Cashin]

On Thu, Feb 12, 2009 at 12:35:05AM +0000, Alex Buell wrote:
> On Wed, 11 Feb 2009 16:29:44 -0800, I waved a wand and this message
> magically appears in front of Andrew Morton:
> 
> > Do you believe that this fix should be backported into earlier kernel
> > versions?  (2.6.28.x, 2.6.27.x, etc)
> 
> Yes, please - I'll be using AoE on these kernels. It might also be a
> good opportunity to update the AoE module, as I believe the latest out
> of the kernel tree module is currently at 70, whilst the version in
> 2.6.27 is at 47.

Yes, my intention is to regularly push patches now that I understand
linux-next and have a quilt tree in place to push patches to it.

-- 
  Ed Cashin <ecashin@coraid.com>

Re: [PATCH 1/1] aoe: ignore vendor extension AoE responses

[Ed Cashin]

On Wed, Feb 11, 2009 at 04:29:44PM -0800, Andrew Morton wrote:
> On Wed, 11 Feb 2009 19:16:44 -0500
> Ed Cashin <ecashin@coraid.com> wrote:
> 
> > The Welland ME-747K-SI AoE target generates unsolicited AoE
> > responses that are marked as vendor extensions.  Instead of
> > ignoring these packets, the aoe driver was generating kernel
> > messages for each unrecognized response received.  This patch
> > corrects the behavior.

...
> Do you believe that this fix should be backported into earlier kernel
> versions?  (2.6.28.x, 2.6.27.x, etc)

It shouldn't hurt, it can help, and it's well tested.

I am not sure how many environments have AoE packets that have vendor
extension command types, though, so I can't gauge how pressing the
need is for backporting.

If the cost of backporting is low, it probably should be backported.

-- 
  Ed Cashin <ecashin@coraid.com>