From: David Brownell <david-b@pacbell.net>
To: felipe.balbi@nokia.com
Cc: Bryan Wu <cooloney@kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mike Frysinger <vapier.adi@gmail.com>
Subject: Re: [PATCH] usb: musb: - kill the compile warning
Date: Thu, 12 Feb 2009 12:30:06 -0800 [thread overview]
Message-ID: <200902121230.06353.david-b@pacbell.net> (raw)
In-Reply-To: <20090212105517.GY12881@scadufax.research.nokia.com>
On Thursday 12 February 2009, Felipe Balbi wrote:
> On Thu, Feb 12, 2009 at 07:03:25AM +0100, David Brownell wrote:
> > On Friday 06 February 2009, Bryan Wu wrote:
> > > - return (MUSB_BUSCTL_OFFSET(i, 0) + mbase);
> > > + return (void __iomem *)(MUSB_BUSCTL_OFFSET(i, 0) + mbase);
> >
> > Why is MUSB_BUSCTL_OFFSET() returning something other than
> > an integer? "mbase" is already "void __iomem *", so the only
> > way that should trigger a warning is if that OFFSET() macro
> > is doing something odd.
>
> The warning only comes on Blackfin's version of this, this hunk is
> unnecessary
We want to get rid of Blackfin-specific warnings too ... but
what I was hinting is that this can't be the right fix.
next prev parent reply other threads:[~2009-02-12 20:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 10:23 [PATCH] usb: musb: - kill the compile warning Bryan Wu
2009-02-06 18:24 ` Felipe Balbi
2009-02-12 6:03 ` David Brownell
2009-02-12 10:55 ` Felipe Balbi
2009-02-12 20:30 ` David Brownell [this message]
2009-02-25 18:16 ` Felipe Balbi
2009-02-27 22:37 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902121230.06353.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=cooloney@kernel.org \
--cc=felipe.balbi@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox