public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Alex Chiang <achiang@hp.com>,
	alex.williamson@hp.com,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sysfs: sysfs_add_one tells you _where_ the duplicate file is
Date: Thu, 12 Feb 2009 08:02:57 -0800	[thread overview]
Message-ID: <20090212160257.GA18786@suse.de> (raw)
In-Reply-To: <ac3eb2510902120105u17f5a0f9q13a228b9ff6ff3d4@mail.gmail.com>

On Thu, Feb 12, 2009 at 10:05:23AM +0100, Kay Sievers wrote:
> On Thu, Feb 12, 2009 at 08:02, Alex Chiang <achiang@hp.com> wrote:
> 
> > sysfs: sysfs_add_one WARNs with full path to duplicate filename
> >
> > As a debugging aid, it can be useful to know the full path to a
> > duplicate file being created in sysfs.
> 
> >        ret = __sysfs_add_one(acxt, sd);
> > -       WARN(ret == -EEXIST, KERN_WARNING "sysfs: duplicate filename '%s' "
> > -                      "can not be created\n", sd->s_name);
> > +       if (ret == -EEXIST) {
> > +               char path[PATH_MAX];
> 
> Isn't that 4k on the stack, and a bit large to put there?

I agree, that's not ok.  Alex, care to redo this?

thanks,

greg k-h

  reply	other threads:[~2009-02-12 16:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11 20:26 [PATCH] sysfs: sysfs_add_one tells you _where_ the duplicate file is Alex Chiang
2009-02-11 22:39 ` Greg KH
2009-02-12  2:56   ` Alex Chiang
2009-02-12  3:02     ` Greg KH
2009-02-12  7:02       ` Alex Chiang
2009-02-12  9:05         ` Kay Sievers
2009-02-12 16:02           ` Greg KH [this message]
2009-02-12 17:38             ` Alex Chiang
2009-02-12 17:41               ` Greg KH
2009-02-12 17:56                 ` Alex Chiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090212160257.GA18786@suse.de \
    --to=gregkh@suse.de \
    --cc=achiang@hp.com \
    --cc=alex.williamson@hp.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox