From: Greg KH <gregkh@suse.de>
To: David Miller <davem@davemloft.net>
Cc: greg@kroah.com, randy.dunlap@oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 9/9] staging/sxg: fix napi interface build
Date: Thu, 12 Feb 2009 16:45:31 -0800 [thread overview]
Message-ID: <20090213004531.GA9791@suse.de> (raw)
In-Reply-To: <20090212.152205.81876086.davem@davemloft.net>
On Thu, Feb 12, 2009 at 03:22:05PM -0800, David Miller wrote:
> From: Greg KH <gregkh@suse.de>
> Date: Thu, 12 Feb 2009 15:08:46 -0800
>
> > On Thu, Feb 12, 2009 at 02:56:20PM -0800, David Miller wrote:
> > > From: Greg KH <greg@kroah.com>
> > > Date: Thu, 12 Feb 2009 11:51:33 -0800
> > >
> > > > On Wed, Feb 11, 2009 at 01:22:56PM -0800, Randy Dunlap wrote:
> > > > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > > > >
> > > > > Fix staging/sxg napi interface calls:
> > > > >
> > > > > drivers/staging/sxg/sxg.c:1271: error: implicit declaration of function 'netif_rx_schedule_prep'
> > > > > linux-next-20090209/drivers/staging/sxg/sxg.c:1272: error: implicit declaration of function '__netif_rx_schedule'
> > > > > drivers/staging/sxg/sxg.c:1325: error: implicit declaration of function 'netif_rx_complete'
> > > >
> > > > As I count over 80 instances of netif_rx_complete in Linus's tree right
> > > > now, I'm guesing this is due to a change from the netdev tree. Which is
> > > > fine, but I'll wait until that gets merged with Linus to apply this
> > > > patch.
> > >
> > > Well it means that it won't build in -next until the next merge
> > > window.
> >
> > I can live with that :)
> >
> > Or is the new api already there and it's safe to make this change now?
>
> If you make the change, your driver will build in Linus's
> tree. Just sed 's/netif_rx_/napi_/' for the lines the
> above warning triggers on.
Ah, sorry, didn't realize that. I'll go apply the patch now, sorry for
the noise...
greg k-h
prev parent reply other threads:[~2009-02-13 0:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 21:22 [PATCH 9/9] staging/sxg: fix napi interface build Randy Dunlap
2009-02-12 19:51 ` Greg KH
2009-02-12 22:56 ` David Miller
2009-02-12 23:08 ` Greg KH
2009-02-12 23:22 ` David Miller
2009-02-13 0:45 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090213004531.GA9791@suse.de \
--to=gregkh@suse.de \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox